Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ci namespace fallback #368

Merged
merged 3 commits into from
Jul 25, 2023
Merged

feat: ci namespace fallback #368

merged 3 commits into from
Jul 25, 2023

Conversation

devthejo
Copy link
Member

@devthejo devthejo commented Jul 24, 2023

@revolunet
Copy link
Member

là si je comprends bien au démarrage il lance une detection du namespace de CI ?

Le NS de ci sert-il a autre chose qu'a stocker les secrets nécessaires ?

@devthejo
Copy link
Member Author

là si je comprends bien au démarrage il lance une detection du namespace de CI ?

yep

Le NS de ci sert-il a autre chose qu'a stocker les secrets nécessaires ?

  • lire le rancherProjectId
  • importer les secrets
  • fallback pour les job si pas de namespace principal
  • faire tourner les jobs hors env, tel que deactivates par ex

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devthejo devthejo merged commit cdc9caa into master Jul 25, 2023
29 of 32 checks passed
@devthejo devthejo deleted the feat/ci-ns-fallback branch July 25, 2023 09:37
@revolunet
Copy link
Member

revolunet commented Jul 26, 2023

On dirait que le ciNamespace du config.yaml n'est pas pris en compte ? https://github.com/SocialGouv/bpco/blob/feat/ovh/.kontinuous/config.yaml#L2

Dans le deploy il demande un autre namespace 🤔

♉ missing rancher projectId, getting from cluster using ci-namespace "ci-bpco" plugin=fabrique/contrib/patches/rancherProjectId
♉ unable to retrieve optional missing rancher projectId from cluster plugin=fabrique/contrib/patches/rancherProjectId error={}

https://github.com/SocialGouv/bpco/actions/runs/5672188574/job/15371418187

@devthejo
Copy link
Member Author

On dirait que le ciNamespace du config.yaml n'est pas pris en compte ? https://github.com/SocialGouv/bpco/blob/feat/ovh/.kontinuous/config.yaml#L2

Dans le deploy il demande un autre namespace 🤔

♉ missing rancher projectId, getting from cluster using ci-namespace "ci-bpco" plugin=fabrique/contrib/patches/rancherProjectId
♉ unable to retrieve optional missing rancher projectId from cluster plugin=fabrique/contrib/patches/rancherProjectId error={}

https://github.com/SocialGouv/bpco/actions/runs/5672188574/job/15371418187

il me semble que le problème ne vient pas de là mais la variable d'env KS_CI_NAMESPACE qui a été definit au niveau du repo et qui vient override celle du fichier de config, il faut la supprimer ici: https://github.com/SocialGouv/bpco/settings/variables/actions

@revolunet
Copy link
Member

bien vu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants