fix: zerodowntime (#481)

SocialGouv · May 28, 2024 · ca8161b · ca8161b
1 parent 7f46715
commit ca8161b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/plugins/contrib/patches/70-zero-downtime-readiness.js b/plugins/contrib/patches/70-zero-downtime-readiness.js
@@ -39,11 +39,10 @@ module.exports = function updateDeploymentManifests(manifests, options = {}) {
           },
           preStop: {
             exec: {
-              // Adding a sleep of gracefulShutdownSeconds before removing the readiness file
               command: [
                 "sh",
                 "-c",
-                `sleep ${gracefulShutdownSeconds}; rm -f /var/run/readiness-check/readiness-file`,
+                `rm -f /var/run/readiness-check/readiness-file; sleep ${gracefulShutdownSeconds}`,
               ],
             },
           },
@@ -69,6 +68,9 @@ module.exports = function updateDeploymentManifests(manifests, options = {}) {
       })
 
       // Ensure the volume does not conflict and is added to the pod spec
+      if (!manifest.spec.template.spec.volumes) {
+        manifest.spec.template.spec.volumes = []
+      }
       if (
         !manifest.spec.template.spec.volumes.some(
           (v) => v.name === "readiness-check-volume"

diff --git a/plugins/fabrique/kontinuous.yaml b/plugins/fabrique/kontinuous.yaml
@@ -22,8 +22,7 @@ dependencies:
 
     patches:
       zeroDowntimeReadiness:
-        # enabled: true
-        enabled: false
+        enabled: true
       certs:
         enabled: true
         options: