Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Task resource v1 readiness #3113

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Oct 3, 2024

Changes

  • Mostly done task resource refactor
  • Sweepers test fixed (they always added errors even when they're nil)
  • Minor changes in SDK (find out the bug with alter task and right now we're only supporting upper-cased warehouse names; added that to the field description)
  • Acceptance tests
  • The enabled field is not a three-valued boolean because it created certain issues when updating the task. The task status is very important for their management and working, so I decided to have them as regular boolean values that are either true or false, nothing in between.

Next prs

  • Apply comments from feat: Tasks v1 readiness - SDK part #3086
  • Data source
  • Move some of the logic to SDK
  • Refactor SDK suspend root logic for tasks (and overall suspend logic in SDK/resource)
  • Examples, documentation, and migration guide
  • More test cases for complicated DAG structures to show the resource can handle more complex structures
  • Analyze non-deterministic test cases
  • Refactor task resuming in task resource (most likely with the use of defer) because currently, there may be cases that error can cause tasks to be not resumed.

References

Copy link

github-actions bot commented Oct 3, 2024

Integration tests failure for 28bf6a5cb6a95fa2d9cb42a558710bb4ad08ee58

@sfc-gh-jcieslak sfc-gh-jcieslak marked this pull request as ready for review October 4, 2024 09:20
Copy link

github-actions bot commented Oct 4, 2024

Integration tests failure for 62adccb771be11faeea226dd4b4b4c29fcea2833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant