chore: Secret Validation change #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for 1c09768bd0697746c0d1bac8e1cc4517c93576d3 |
sfc-gh-jmichalak
approved these changes
Oct 4, 2024
| @@ -19,7 +19,7 @@ func TestInt_Secrets(t *testing.T) { | |||
|
|
|||
| integrationId := testClientHelper().Ids.RandomAccountObjectIdentifier() | |||
|
|
|||
| // "YYYY-MM-DD" or "YYYY-MM-DD HH-MI-SS" format has to be used, otherwise Snowflake returns error: "Invalid date/time format" | |||
| // "YYYY-MM-DD" or "YYYY-MM-DD HH:MI-SS" format has to be used, otherwise Snowflake returns error: "Invalid date/time format" | |||
There was a problem hiding this comment.
Nit: just asking: shouldn't it be HH:MI:SS?
There was a problem hiding this comment.
It should, will fix this with next PR
| @@ -121,7 +120,7 @@ func TestInt_Secrets(t *testing.T) { | |||
| }) | |||
| }) | |||
|
|
|||
| // regarding the https://docs.snowflake.com/en/sql-reference/sql/create-secret secret with empty oauth_scopes list should inherit scopes from security_integration, but it does not | |||
| // TODO [SNOW-1678756]: oauth_copes not inherited or not displayed correctly when not provided | |||
There was a problem hiding this comment.
Nit: oauth_scopes
There was a problem hiding this comment.
Will correct it with next Secret related PR
| opts.Set.SetForFlow.SetForOAuthClientCredentials = &SetForOAuthClientCredentials{OauthScopes: &OauthScopesList{[]ApiIntegrationScope{{Scope: "foo"}}}} | ||
| opts.Set.SetForFlow.SetForOAuthAuthorization = &SetForOAuthAuthorization{OauthRefreshToken: String("foo"), OauthRefreshTokenExpiryTime: String("bar")} | ||
| opts.Set.SetForFlow.SetForBasicAuthentication = &SetForBasicAuthentication{Username: String("foo"), Password: String("bar")} | ||
| opts.Set.SetForFlow.SetForGenericString = &SetForGenericString{SecretString: String("secret")} |
There was a problem hiding this comment.
Nit: These 5 statements can be done like:
opts.Set.SetForFlow = &SetForFlow{
SetForOAuthClientCredentials: &SetForOAuthClientCredentials{OauthScopes: &OauthScopesList{[]ApiIntegrationScope{{Scope: "foo"}}}}
...
}
There was a problem hiding this comment.
will do this way next time and change it with next Secret PRs
sfc-gh-jcieslak
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ParseCommaSeparatedStringArray()