fix: Fix parsing text in view, check parenthesis in ParseSchemaObjectIdentifierWithArguments #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for beee8a5c83b93782e12a2c002ca2c58ceab44351 |
|
Integration tests failure for e8a82da3d173de9b3c9997798ab2381bd48de986 |
sfc-gh-jcieslak
previously approved these changes
Sep 24, 2024
|
Integration tests failure for 2bd249362fb2cc919ee75e2c44ba17b6f69960a3 |
|
Integration tests failure for b288c28fdaeb6c4b60d226486a04ffbbbec22d68 |
sfc-gh-jcieslak
approved these changes
Oct 2, 2024
sfc-gh-asawicki
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
References
#3073 (comment)
Summary
fix: add a check for
(in ParseSchemaObjectIdentifierWithArguments; add a unit testfix: improve view parser; add unit tests
docs: add a note to docs that we discourage using special characters in views
docs: add granting PUBLIC role to common issues
docs: add a recommendation about upgrading versions one by one
docs: adjust essential objects table