fix: snowpipe error integration

[sonya]

This PR fixes a bug where setting error_integration on a snowflake_pipe resource would cause the name of the integration to be written to the comment field on the pipe instead of the error integration. A separate bug prevented the error_integration diffs from being detected if an SNS topic was set.

Test Plan

I tested this using an existing stack where I have many pipes. I made an earnest attempt to update pipes_integration_test.go, but I reached the point where I needed a real SNS topic and decided that was beyond the timebox I set for this.

Using version 0.76.0:

1. Started with already deployed pipes that had a comment but no error_integration
2. Added error_integration to the terraform config.
3. terraform apply
4. Ran describe pipe on the updated pipes in Snowflake. The comments now contained the name of the notification integration, whereas error_integration was null.
5. terraform apply again with no changes
6. Ran describe pipe on the updated pipes in Snowflake. The comments were back to their previous value, but error_integration was still null.
7. Removed error_integration from the terraform config.
8. terraform apply
9. Ran describe pipe on the updated pipes in Snowflake. The comments were now blank.

Using the modified provider

1. Started with pipes that had a comment but no error_integration
2. Added error_integration to the terraform config.
3. terraform apply
4. Ran describe pipe on the updated pipes in Snowflake. The comments were unchanged and error integrations were set to the expected value.
5. Removed error_integration from the terraform config
6. terraform apply
7. Ran describe pipe on the updated pipes in Snowflake. The comments were unchanged, and error integrations were null.

References

I initially started to file a bug report, but during investigation I figured out how to fix it so I'm opening a PR instead. Let me know if this isn't the right process

[sfc-gh-asawicki]

Hey @sonya. Thanks for the contribution!

We will review it in the upcoming days. cc: @sfc-gh-jcieslak @scottwinkler

[sfc-gh-jcieslak]

Thanks for contributing, looks good to me 👍

[sfc-gh-asawicki]

Quick question: documentation does not list ErrorIntegration as a possible value for UNSET https://docs.snowflake.com/en/sql-reference/sql/alter-pipe#parameters. I guess that this is an error in the docs, right?

[sfc-gh-jcieslak]

Yeah, I checked it and it works

[sfc-gh-asawicki]

/ok-to-test sha=3c8f11d1fb023894a04dd4e696fe61f446d0db3b

[github-actions]

Integration tests failure for 3c8f11d1fb023894a04dd4e696fe61f446d0db3b