Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add unsafe_execute resource #2225

Merged
merged 28 commits into from
Nov 30, 2023
Merged

feat: Add unsafe_execute resource #2225

merged 28 commits into from
Nov 30, 2023

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Nov 30, 2023 •
edited
Loading

Introduce unsafe_execute experimental resource.

The resource is not recommended to be used in production environments. It consists of:

  • required execute and revert - they are not validated in any way
  • optional query that fetches results and updates query_results; in case of error clears query_results

sfc-gh-jcieslak and others added 26 commits November 24, 2023 14:58
@sfc-gh-jcieslak
add unsafe exec resource
522d7ef
@sfc-gh-asawicki
Rename resource and make the basic tests pass
11e29a3
@sfc-gh-asawicki
Simplify tests setup
3a7d252
@sfc-gh-asawicki
Rename resource args
4b27f0a
@sfc-gh-asawicki
Fix checking db existence
80816c3
@sfc-gh-asawicki
Add random part to id
40b4853
@sfc-gh-asawicki
Rename migration
6c8c25a
@sfc-gh-asawicki
Remove unnecessary config param
3b441f4
@sfc-gh-asawicki
Remove duplicated checks
089bc49
@sfc-gh-asawicki
Extract function to generate capitalized name
73812b3
@sfc-gh-asawicki
Test escaped identifier
7b4671c
@sfc-gh-asawicki
Test unsafe execute with grants
392489d
@sfc-gh-asawicki
Add TODO
b3dfda1
@sfc-gh-asawicki
Add test with HCL for_each
0348022
@sfc-gh-asawicki
Fix before pushing
6cd3f2c
@sfc-gh-asawicki
Update docs with warning
2860e11
@sfc-gh-asawicki
Update example usage in docs
f8e0544
@sfc-gh-asawicki
Merge branch 'main' into unsafe-exec-resource
ec4c51a
@sfc-gh-asawicki
Add negative tests
d3fa76e
@sfc-gh-asawicki
Add read (WIP)
9e75ac2
@sfc-gh-asawicki
Pass test without query
9f4a7b5
@sfc-gh-asawicki
Add test for query removed
227668f
@sfc-gh-asawicki
Move unsafe client and implementation to SDK
4af38eb
@sfc-gh-asawicki
Fix query unsafe
a1fc3cb
@sfc-gh-asawicki
Update docs and change query behavior
6101ad6
@sfc-gh-asawicki
Update docs
e0f00c4
@sfc-gh-asawicki sfc-gh-asawicki changed the title feat: Unsafe exec resource feat: Add unsafe_execute resource Nov 30, 2023
@github-actions GitHub Actions
Copy link

Integration tests failure for e0f00c413248dfbf32c717e87cf74928fca5a38f

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review November 30, 2023 11:43
@github-actions GitHub Actions
Copy link

Integration tests failure for 4d3ba5d39a17ba6984f07f4818a8c36cf798d780

@sfc-gh-asawicki sfc-gh-asawicki merged commit 196134c into main Nov 30, 2023
7 of 8 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the unsafe-exec-resource branch November 30, 2023 12:56
@snowflake-release-please snowflake-release-please bot mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

@sfc-gh-swinkler sfc-gh-swinkler Awaiting requested review from sfc-gh-swinkler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-asawicki @sfc-gh-jcieslak