feat: add event tables to sdk #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| // CreateEventTableOptions is based on https://docs.snowflake.com/en/sql-reference/sql/create-event-table. | ||
| type CreateEventTableOptions struct { | ||
| create bool `ddl:"static" sql:"CREATE"` |
| type CreateEventTableOptions struct { | ||
| create bool `ddl:"static" sql:"CREATE"` | ||
| OrReplace *bool `ddl:"keyword" sql:"OR REPLACE"` | ||
| eventTable bool `ddl:"static" sql:"EVENT TABLE"` |
pkg/sdk/event_tables_gen.go
Outdated
|
|
||
| // ShowEventTableOptions is based on https://docs.snowflake.com/en/sql-reference/sql/show-event-tables. | ||
| type ShowEventTableOptions struct { | ||
| show bool `ddl:"static" sql:"SHOW"` |
pkg/sdk/event_tables_gen.go
Outdated
| // ShowEventTableOptions is based on https://docs.snowflake.com/en/sql-reference/sql/show-event-tables. | ||
| type ShowEventTableOptions struct { | ||
| show bool `ddl:"static" sql:"SHOW"` | ||
| eventTables bool `ddl:"static" sql:"EVENT TABLES"` |
|
|
||
| // DescribeEventTableOptions is based on https://docs.snowflake.com/en/sql-reference/sql/describe-event-table. | ||
| type DescribeEventTableOptions struct { | ||
| describe bool `ddl:"static" sql:"DESCRIBE"` |
pkg/sdk/event_tables_gen.go
Outdated
|
|
||
| // AlterEventTableOptions is based on https://docs.snowflake.com/en/sql-reference/sql/alter-event-table. | ||
| type AlterEventTableOptions struct { | ||
| alter bool `ddl:"static" sql:"ALTER"` |
pkg/sdk/event_tables_gen.go
Outdated
| // AlterEventTableOptions is based on https://docs.snowflake.com/en/sql-reference/sql/alter-event-table. | ||
| type AlterEventTableOptions struct { | ||
| alter bool `ddl:"static" sql:"ALTER"` | ||
| eventTable bool `ddl:"static" sql:"TABLE"` |
pkg/sdk/event_tables_gen.go
Outdated
| } | ||
|
|
||
| type EventTableDropRowAccessPolicy struct { | ||
| rowAccessPolicy bool `ddl:"static" sql:"ROW ACCESS POLICY"` |
| } | ||
|
|
||
| type SearchOptimization struct { | ||
| searchOptimization bool `ddl:"static" sql:"SEARCH OPTIMIZATION"` |
| return opts | ||
| } | ||
|
|
||
| func (r eventTableRow) convert() *EventTable { |
|
Integration tests failure for 3ac856ad207507859ab81dab506ed8161769fbda |
sfc-gh-asawicki
requested changes
Nov 27, 2023
|
|
||
| // ShowEventTableOptions is based on https://docs.snowflake.com/en/sql-reference/sql/show-event-tables. | ||
| type ShowEventTableOptions struct { | ||
| show bool `ddl:"static" sql:"SHOW"` |
| // ShowEventTableOptions is based on https://docs.snowflake.com/en/sql-reference/sql/show-event-tables. | ||
| type ShowEventTableOptions struct { | ||
| show bool `ddl:"static" sql:"SHOW"` | ||
| eventTables bool `ddl:"static" sql:"EVENT TABLES"` |
|
|
||
| // DropEventTableOptions is based on https://docs.snowflake.com/en/sql-reference/sql/drop-event-table. | ||
| type DropEventTableOptions struct { | ||
| drop bool `ddl:"static" sql:"DROP"` |
| // DropEventTableOptions is based on https://docs.snowflake.com/en/sql-reference/sql/drop-event-table. | ||
| type DropEventTableOptions struct { | ||
| drop bool `ddl:"static" sql:"DROP"` | ||
| table bool `ddl:"static" sql:"TABLE"` |
|
|
||
| // AlterEventTableOptions is based on https://docs.snowflake.com/en/sql-reference/sql/alter-event-table. | ||
| type AlterEventTableOptions struct { | ||
| alter bool `ddl:"static" sql:"ALTER"` |
| // AlterEventTableOptions is based on https://docs.snowflake.com/en/sql-reference/sql/alter-event-table. | ||
| type AlterEventTableOptions struct { | ||
| alter bool `ddl:"static" sql:"ALTER"` | ||
| table bool `ddl:"static" sql:"TABLE"` |
| } | ||
|
|
||
| type EventTableAddRowAccessPolicy struct { | ||
| add bool `ddl:"static" sql:"ADD"` |
| } | ||
|
|
||
| type EventTableDropRowAccessPolicy struct { | ||
| drop bool `ddl:"static" sql:"DROP"` |
| return t | ||
| } | ||
|
|
||
| func (r *DescribeEventTableRequest) toOpts() *DescribeEventTableOptions { |
|
Integration tests failure for f68a196cb7bddc86da86fe03007844d4fb8bd63e |
|
Integration tests failure for 6d26e1e6379bc60ca99ec6cb3e5572ce85c1f1ce |
pkg/sdk/event_tables_def.go
Outdated
| Name(). | ||
| WithValidation(g.ValidIdentifier, "name"), | ||
| ).DropOperation( | ||
| "https://docs.snowflake.com/en/sql-reference/sql/drop-event-table", |
There was a problem hiding this comment.
it should point to the drop table page (there's no such page as drop event table)
sfc-gh-asawicki
previously approved these changes
Nov 30, 2023
|
Integration tests failure for 38fffb91a9dcee635def5460e7ec0246dcbeffaf |
|
Integration tests failure for 9f2e0bd082b9b972068cc506cc5d36cd1165a208 |
|
Integration tests failure for c884a41259b4d218f832a780d30f73d5f7706065 |
17 tasks
sfc-gh-jcieslak
approved these changes
Dec 5, 2023
|
Integration tests failure for 5d68d59bb599b3e38d52ecb4fa8624c41398dfca |
sfc-gh-asawicki
approved these changes
Dec 7, 2023
|
Integration tests failure for b43974480aa4bad94d350d1ec09dc5aa35ea7ec2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.snowflake.com/en/sql-reference/sql/create-event-table