fix: changing masking policy on a column requires FORCE #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See docs: https://docs.snowflake.com/en/user-guide/security-column-intro#replace-a-masking-policy-on-a-column Attempting to change masking policy without FORCE would cause the following error: 003529 (42601): Specified column already attached to another masking policy. A column cannot be attached to multiple masking policies. Please drop the current association in order to attach a new masking policy. This PR adds FORCE to the generated ALTER statement. It also adds table acceptance tests that cover masking policy creation and change
malduarte
force-pushed
the
update_masking_policy
branch
from
a2528d6
to
fe03432
Compare
|
Hey @malduarte. Thanks for the contribution. Unfortunately, we are currently changing the implementation used in resources as a part of our ongoing SDK rewrite. This means we will eliminate table implementation residing in the However, we will add this behavior as a part of the process. |
|
@sfc-gh-asawicki Is there an active branch? I'm happy to submit the MR there |
|
Yes, there is an open PR: #2042. There will be a subsequent PR that will replace current resource implementation with the one in the linked PR but there is no branch for that yet. |
sfc-gh-asawicki
added a commit
that referenced
this pull request
Feb 2, 2024
- Migrate tables resource and datasource - Remove old implementation - Fix issue with masking policies update (check #2186)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to change masking policy without FORCE would cause the following error:
003529 (42601): Specified column already attached to another masking policy. A column cannot be attached to multiple masking policies. Please drop the current association in order to attach a new masking policy.
This PR adds FORCE to the generated ALTER statement and improves error information if masking policy change fails to apply.
Test Plan
Added TestAcc_TableWithMaskingPolicy that
References