Skip to content

Commit

Permalink
lint fix
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-jcieslak committed Sep 23, 2024
1 parent 554fc90 commit 87638ea
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 12 deletions.
2 changes: 0 additions & 2 deletions docs/resources/shared_database.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ resource "snowflake_shared_database" "test" {
from_share = "<primary_account_organization_name>.<primary_account_name>.${snowflake_share.test.name}"
comment = "A shared database"
data_retention_time_in_days = 10
max_data_extension_time_in_days = 20
external_volume = "<external_volume_name>"
catalog = "<catalog_name>"
replace_invalid_characters = false
Expand Down
2 changes: 0 additions & 2 deletions examples/resources/snowflake_shared_database/resource.tf
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ resource "snowflake_shared_database" "test" {
from_share = "<primary_account_organization_name>.<primary_account_name>.${snowflake_share.test.name}"
comment = "A shared database"

data_retention_time_in_days = 10
max_data_extension_time_in_days = 20
external_volume = "<external_volume_name>"
catalog = "<catalog_name>"
replace_invalid_characters = false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,8 @@ var allObjectsParameters = []SnowflakeObjectParameters{
// TODO [SNOW-1501905]: quick workaround for now: lowercase for ignore in snowflake by default but uppercase for FAIL
{ParameterName: string(sdk.TaskParameterUnsupportedDdlAction), ParameterType: "sdk.UnsupportedDDLAction", DefaultValue: "sdk.UnsupportedDDLAction(strings.ToLower(string(sdk.UnsupportedDDLActionIgnore)))", DefaultLevel: "sdk.ParameterTypeSnowflakeDefault"},
{ParameterName: string(sdk.TaskParameterUserTaskManagedInitialWarehouseSize), ParameterType: "sdk.WarehouseSize", DefaultValue: "Medium", DefaultLevel: "sdk.ParameterTypeSnowflakeDefault"},
//{ParameterName: string(sdk.UserParameterUnsupportedUserTaskMinimumTriggerIntervalInSeconds), ParameterType: "int", DefaultValue: "30", DefaultLevel: "sdk.ParameterTypeSnowflakeDefault"},
//{ParameterName: string(sdk.UserParameterUnsupportedUserTaskTimeoutMs), ParameterType: "int", DefaultValue: "3600000", DefaultLevel: "sdk.ParameterTypeSnowflakeDefault"},
// {ParameterName: string(sdk.UserParameterUnsupportedUserTaskMinimumTriggerIntervalInSeconds), ParameterType: "int", DefaultValue: "30", DefaultLevel: "sdk.ParameterTypeSnowflakeDefault"},
// {ParameterName: string(sdk.UserParameterUnsupportedUserTaskTimeoutMs), ParameterType: "int", DefaultValue: "3600000", DefaultLevel: "sdk.ParameterTypeSnowflakeDefault"},
{ParameterName: string(sdk.TaskParameterUseCachedResult), ParameterType: "bool", DefaultValue: "true", DefaultLevel: "sdk.ParameterTypeSnowflakeDefault"},
{ParameterName: string(sdk.TaskParameterWeekOfYearPolicy), ParameterType: "int", DefaultValue: "0", DefaultLevel: "sdk.ParameterTypeSnowflakeDefault"},
{ParameterName: string(sdk.TaskParameterWeekStart), ParameterType: "int", DefaultValue: "0", DefaultLevel: "sdk.ParameterTypeSnowflakeDefault"},
Expand Down
13 changes: 7 additions & 6 deletions pkg/sdk/testint/tasks_gen_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@ package testint

import (
"fmt"
"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/bettertestspoc/assert/objectparametersassert"
"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/helpers/random"
"testing"
"time"

"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/bettertestspoc/assert/objectparametersassert"
"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/helpers/random"

assertions "github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/bettertestspoc/assert"
"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/bettertestspoc/assert/objectassert"

Expand Down Expand Up @@ -505,9 +506,9 @@ func TestInt_Tasks(t *testing.T) {
require.NoError(t, err)

// TODO(SNOW-1348116 - next prs): Assert parameters
//assertions.AssertThat(t, objectparametersassert.TaskParameters(t, task.ID()).
// assertions.AssertThat(t, objectparametersassert.TaskParameters(t, task.ID()).
// HasUserTaskManagedInitialWarehouseSize()
//)
// )

assertions.AssertThat(t, objectassert.Task(t, task.ID()).
// HasWarehouse(testClientHelper().Ids.WarehouseId().Name()).
Expand Down Expand Up @@ -545,9 +546,9 @@ func TestInt_Tasks(t *testing.T) {
)

// TODO(SNOW-1348116 - next prs): Assert parameters
//assertions.AssertThat(t, objectparametersassert.TaskParameters(t, task.ID()).
// assertions.AssertThat(t, objectparametersassert.TaskParameters(t, task.ID()).
// HasUserTaskManagedInitialWarehouseSize()
//)
// )
})

t.Run("alter task: set and unset tag", func(t *testing.T) {
Expand Down

0 comments on commit 87638ea

Please sign in to comment.