Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#104299 - Updated snowdog-menu block id #309

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Conversation

maartynaa
Copy link
Contributor

No description provided.

@@ -40,8 +43,10 @@ public function __construct(
MenuFactory $menuFactory,
CollectionFactory $menuCollectionFactory,
MenuSearchResultsInterfaceFactory $menuSearchResults,
MenuInterface $menu,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a fan of injecting MenuInterface directly as it is data object - especially in this context where we also have MenuFactory (but this is not true for 2 other instances).
Maybe this should be some kind of helper to provide link fields?

@@ -46,6 +46,7 @@ $blockHtmlId = $block->getBlockHtmlId();
"imageDeleteUrl" : "<?= $block->getImageDeleteUrl() ?>",
"imageUploadFileId": "<?= $block->getImageUploadFileId() ?>",
"lazyMinItemsCount": "1000",
"serializedNodesElementName": "serialized_nodes",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: pass the correct value from backend (either "serialized_nodes" or "snowmenu_staging_serialized_nodes")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants