feature/update-label #282
Merged
feature/update-label #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/snowdog/alpaca-ui/h0guqc8z0 |
zuzannaszymanda
force-pushed
the
feature/update-label
branch
from
967c103
to
f63fb8a
Compare
|
Please check unit test issue |
szafran89
reviewed
Jul 31, 2020
src/atoms/label/Label.css
Outdated
| @@ -0,0 +1,15 @@ | |||
|
|
|||
There was a problem hiding this comment.
remove this empty line. I will add some lint for this file
src/atoms/label/Label.js
Outdated
| @@ -2,7 +2,7 @@ | |||
| export default { | |||
| props: { | |||
| /** | |||
| * Label tag | |||
| * To use another tag instead of 'label' | |||
| */ | |||
| tag: { | |||
There was a problem hiding this comment.
IMO custom tag is unnecessary, WDYT is there any use case for custom tag?
There was a problem hiding this comment.
not really, I'll change component to label
src/atoms/label/Label.vue
Outdated
| @@ -10,4 +10,4 @@ export default { | |||
| } | |||
| </script> | |||
|
|
|||
| <style lang="scss" src="./Label.scss" /> | |||
| <style lang="css" src="./Label.css" /> | |||
src/atoms/label/Label.css
Outdated
| @apply block; | ||
| @apply mb-1; | ||
| @apply text-gray-600 font-normal text-base font-sans leading-relaxed; | ||
| @apply transition-none; |
There was a problem hiding this comment.
Hmm.. do we need this line?
szafran89
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.