Feautre/261 Heading component review #266
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/snowdog/alpaca-ui/kucp7rpsl |
ofrankowska
changed the title
src/atoms/heading/Heading.scss
Outdated
| $headings-font-weight : $font-weight-medium !default; | ||
| $headings-line-height : $font-line-height !default; | ||
| $headings-color : $color-primary !default; | ||
| $headings-text-transform : uppercase !default; |
There was a problem hiding this comment.
as I can see it should not be uppercase by default.
src/atoms/heading/Heading.scss
Outdated
| $heading-font-size--first-level : $font-size-extra-large !default; | ||
| $heading-font-size--second-level\@screen-m: $font-size-extra-large !default; | ||
| $heading-font-size--second-level : $font-size-large !default; | ||
| $heading-font-size--third-level\@screen-m : $font-size-large !default; |
There was a problem hiding this comment.
IMO we should do it as simple as possible. Maybe it would be good do keep 1 size for one heading for now? @anqaka WDYT?
There was a problem hiding this comment.
Regarding to UX, I think smaller font-size for h1 and h2 for mobile view is often requested and useful, not sure about h3
There was a problem hiding this comment.
ok, lets leave this problem for now
No description provided.