Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix building using system TLS and hiredis #807

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guillemj
Copy link
Contributor

The commit to add support to use the system hiredis entangled the TLS and hiredis system ussage, but while related, the TLS support is not conditional on whether we use the system hiredis.

Detangle them so that we link against the system OpenSSL libraries again.

Fixes: commit 657229a

The commit to add support to use the system hiredis entangled the TLS
and hiredis system ussage, but while related, the TLS support is not
conditional on whether we use the system hiredis.

Detangle them so that we link against the system OpenSSL libraries
again.

Fixes: commit 657229a
@JohnSully
Copy link
Collaborator

JohnSully commented Apr 4, 2024

I'm a bit suspicious of the CI failures will need a deeper dive

{12008:12023:S 26 Mar 2024 19:57:42.694 # Internal error in RDB reading offset 9610080, function at rdb.c:3529 -> Unexpected EOF reading RDB file. Failure loading rdb format from socket, assuming connection error, resuming operation.} 52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants