Renamed REDISPORT => KeyDBPORT #241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnSully
requested changes
Oct 4, 2020
utils/keydb_init_script
Outdated
| ### END INIT INFO | ||
|
|
||
| REDISPORT=6379 | ||
| KeyDBPORT=6379 |
There was a problem hiding this comment.
bash variable names are typically all uppercase.
|
The bash variable name needs to keep with the coding standards used elsewhere (all uppercase). Otherwise great change. |
Signed-off-by: Hanif Bin Ariffin <[email protected]>
hbina
force-pushed
the
rename_var_in_script
branch
from
6a2340f
to
cc67725
Compare
e271828-
reviewed
Oct 4, 2020
e271828-
reviewed
Oct 4, 2020
Comment on lines
+18
to
+19
| PIDFILE=/var/run/redis_${KEYDBPORT}.pid | ||
| CONF="/etc/redis/${KEYDBPORT}.conf" |
There was a problem hiding this comment.
Presumably these dirs should change? @JohnSully
Co-authored-by: e271828- <[email protected]>
JohnSully
pushed a commit
that referenced
this pull request
Feb 1, 2024
update insufficient replicas metrics to separate severity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the documentation.