Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In debug logging, print 'fixed' values as floats #712

Closed
wants to merge 1 commit into from

Conversation

colinmarc
Copy link
Contributor

I got a bit confused by the following:

2024-04-17T19:51:21.930954Z DEBUG session{session_id=365288}: mmserver::compositor: wheel delta: 0.0 -48.0
[ 768472.301][rs] -> [email protected]_source(2)
[ 768472.333][rs] -> [email protected](13025, 0, -12288)

@ids1024
Copy link
Member

ids1024 commented May 8, 2024

This seems to match wayland-backend/client_system, except libwayland prints more than 4 digits.

Truncating to 4 digits makes sense given it doesn't have that much precision anyway.

I guess this should have a CHANGELOG entry.

Copy link
Member

@elinorbgr elinorbgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a changelog entry as pointed by @ids1024

@ids1024 ids1024 mentioned this pull request May 30, 2024
@ids1024
Copy link
Member

ids1024 commented May 30, 2024

Merged with a changelog entry as part of #732. Thanks!

@ids1024 ids1024 closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants