Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Frame::{set_,}{up,down}scale_filter() #1329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YaLTeR
Copy link
Contributor

@YaLTeR YaLTeR commented Feb 13, 2024

Allows changing the filter on the fly, especially useful within RenderElements::draw() where the renderer is inaccessible.

Example use: YaLTeR/niri#189

@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (91e61f1) 21.32% compared to head (0c06b78) 21.31%.

Files Patch % Lines
src/backend/renderer/test.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
- Coverage   21.32%   21.31%   -0.01%     
==========================================
  Files         156      156              
  Lines       25121    25129       +8     
==========================================
  Hits         5356     5356              
- Misses      19765    19773       +8     
Flag Coverage Δ
wlcs-buffer 18.41% <0.00%> (-0.01%) ⬇️
wlcs-core 18.09% <0.00%> (-0.01%) ⬇️
wlcs-output 7.75% <0.00%> (-0.01%) ⬇️
wlcs-pointer-input 20.12% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Drakulix
Copy link
Member

I wonder if this blurs the lines in terms of expectations of what state is local to a Frame.

Maybe this should be reset on dropping the Frame?

Allows changing the filter on the fly, especially useful within
RenderElements::draw() where the renderer is inaccessible.
@SergioRibera
Copy link

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants