Fix clippy unnecessary_cast lint

Removed the case where `bindings.rs` defined the constants as `u32`, but allowed the lint where it instead uses a type alias defined as `libc::c_uint` (which tecnically may not be 32-bit).
Smithay · Sep 27, 2024 · ccd9186 · ccd9186
1 parent c6c22c5
commit ccd9186
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/buffer_object.rs b/src/buffer_object.rs
@@ -1,3 +1,5 @@
+#![allow(clippy::unnecessary_cast)]
+
 use crate::{AsRaw, Device, DeviceDestroyedError, Format, Modifier, Ptr, WeakPtr};
 
 #[cfg(feature = "drm-support")]

diff --git a/src/device.rs b/src/device.rs
@@ -265,7 +265,7 @@ impl<T: AsFd> Device<T> {
         let ptr = unsafe {
             ffi::gbm_bo_import(
                 *self.ffi,
-                ffi::GBM_BO_IMPORT_WL_BUFFER as u32,
+                ffi::GBM_BO_IMPORT_WL_BUFFER,
                 buffer.id().as_ptr() as *mut _,
                 usage.bits(),
             )
@@ -298,7 +298,7 @@ impl<T: AsFd> Device<T> {
     ) -> IoResult<BufferObject<U>> {
         let ptr = ffi::gbm_bo_import(
             *self.ffi,
-            ffi::GBM_BO_IMPORT_EGL_IMAGE as u32,
+            ffi::GBM_BO_IMPORT_EGL_IMAGE,
             buffer,
             usage.bits(),
         );
@@ -337,7 +337,7 @@ impl<T: AsFd> Device<T> {
         let ptr = unsafe {
             ffi::gbm_bo_import(
                 *self.ffi,
-                ffi::GBM_BO_IMPORT_FD as u32,
+                ffi::GBM_BO_IMPORT_FD,
                 &mut fd_data as *mut ffi::gbm_import_fd_data as *mut _,
                 usage.bits(),
             )
@@ -385,7 +385,7 @@ impl<T: AsFd> Device<T> {
         let ptr = unsafe {
             ffi::gbm_bo_import(
                 *self.ffi,
-                ffi::GBM_BO_IMPORT_FD_MODIFIER as u32,
+                ffi::GBM_BO_IMPORT_FD_MODIFIER,
                 &mut fd_data as *mut ffi::gbm_import_fd_modifier_data as *mut _,
                 usage.bits(),
             )