Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Fix issue when task is scheduled within event callback #172

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Jan 29, 2024

I believe this should be overall more correct. Previously, if the callback taken by process_events scheduled a task, process_events could exit with the readiness of self.ping cleared, but notified set to true. In which case, future calls to schedule would not wake the event source.

Fixes #171.

I believe this should be overall more correct. Previously, if the
callback taken by `process_events` scheduled a task, `process_events`
could exit with the readiness of `self.ping` cleared, but `notified` set
to `true`. In which case, future calls to `schedule` would not wake the
event source.

Fixes Smithay#171.
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd9c3f3) 86.30% compared to head (0b79bee) 86.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   86.30%   86.26%   -0.04%     
==========================================
  Files          16       16              
  Lines        2044     2039       -5     
==========================================
- Hits         1764     1759       -5     
  Misses        280      280              
Flag Coverage Δ
macos-latest 85.38% <100.00%> (-0.01%) ⬇️
ubuntu-latest 85.85% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notgull notgull self-assigned this Jan 30, 2024
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@notgull notgull merged commit 9abedf1 into Smithay:master Jan 30, 2024
12 of 13 checks passed
@notgull notgull mentioned this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all tasks scheduled with Executor are run
2 participants