deps: Fix compiling with minimal versions #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 86.65% 86.65%
=======================================
Files 16 16
Lines 1933 1933
=======================================
Hits 1675 1675
Misses 258 258
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
elinorbgr
approved these changes
Oct 9, 2023
notgull
added a commit
that referenced
this pull request
Jan 13, 2024
This commit adds Windows support to this package. Since polling already has Windows support through IOCP, the main obstacle was adding a ping event source using IOCP. The hardest part is emulating a pipe using some shared state and a posted completion packet. Fixes #160 Signed-off-by: John Nunley <[email protected]>
Merged
notgull
added a commit
that referenced
this pull request
Jan 15, 2024
This commit adds Windows support to this package. Since polling already has Windows support through IOCP, the main obstacle was adding a ping event source using IOCP. The hardest part is emulating a pipe using some shared state and a posted completion packet. Fixes #160 Signed-off-by: John Nunley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.