Fix crash when dropping removed token

[chrisduerr]

This fixes an issue where calloop would crash internally when the PostAction::Drop was invoked after the user manually cancelled the source in the callback.

[codecov]

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (7ae6f36) 86.84% compared to head (d4e9304) 86.75%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   86.84%   86.75%   -0.10%     
==========================================
  Files          14       14              
  Lines        1817     1819       +2     
==========================================
  Hits         1578     1578              
- Misses        239      241       +2     

Flag	Coverage Δ
macos-latest	85.79% <74.57%> (-0.11%)	⬇️
ubuntu-latest	86.28% <74.57%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/loop_logic.rs	87.03% <74.57%> (-0.51%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[elinorbgr]

Could you give a quick summary of what you changed and why? This diff is not very clear to read...

[chrisduerr]

Could you give a quick summary of what you changed and why? This diff is not very clear to read...

Just changed the remove to try_remove. Just also tried to make the code somewhat readable at least.

[kchibisov]

This probably needs a test given that it sounds like simple to repro?

[elinorbgr]

Alright, I took the time to figure out exactly what happens, and this seems like a good way to fix this, thanks.

Could you please just add a changelog entry for this under the "unreleased" section?

[elinorbgr]

Ok so, it appears that a deeper issue with this PR as a special case was found & fixed in #156.

[elinorbgr]

closing in favor of #156