Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage testing on the CI #150

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

kchibisov
Copy link
Member

The way coverage is enabled/disabled was changed upstream.

Links: rust-lang/rust#114656

The way coverage is enabled/disabled was changed upstream.

Links: rust-lang/rust#114656
@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1c2fd23) 86.82% compared to head (a3501cf) 86.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   86.82%   86.82%           
=======================================
  Files          14       14           
  Lines        1806     1806           
=======================================
  Hits         1568     1568           
  Misses        238      238           
Flag Coverage Δ
macos-latest 85.86% <ø> (ø)
ubuntu-latest 86.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/error.rs 0.00% <ø> (ø)
src/io.rs 73.93% <ø> (ø)
src/loop_logic.rs 86.90% <ø> (ø)
src/sources/channel.rs 77.14% <ø> (ø)
src/sources/mod.rs 95.18% <ø> (ø)
src/sources/timer.rs 86.53% <ø> (ø)
src/sys.rs 98.49% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kchibisov
Copy link
Member Author

First time I see coverage test pass on my PR, impressive.

@elinorbgr
Copy link
Member

Thanks!

@elinorbgr elinorbgr merged commit 2feb1cf into Smithay:master Sep 18, 2023
12 checks passed
@kchibisov kchibisov deleted the fix-coverage-ci branch September 18, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants