Update for new polling breaking changes

[notgull]

For now, this exists as a testing ground in order to test smol-rs/polling#123 before we release it.

[ids1024]

So, this makes Generic safe by having Drop and unwrap automatically unregister it from the event loop?

Interesting approach. Normally relying on Drop for safety properties is unsound, with mem::forget or reference cycles, but in this particular instance it's fine since that will also leak the fd. (In other words, I tried to break this and get it to poll an invalid fd using Generic, but I couldn't. So it looks sound.)

But this does mean that if a user of calloop implements EventSource to call Poll::register etc. directly, it should also implement Drop like this to ensure the same safety properties?

[notgull]

The only thing that matters is that the source isn't dropped while registered in a Poller. If anyone were to implement a similar abstraction to this, they would need to either follow these dropping rules or otherwise make sure that drop() isn't called before deregister().

[notgull]

I've updated this for the new polling release.

[codecov]

Codecov Report

Patch coverage: 82.69% and project coverage change: +0.17% 🎉

Comparison is base (d468cc9) 88.79% compared to head (4e805d6) 88.97%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   88.79%   88.97%   +0.17%     
==========================================
  Files          14       14              
  Lines        1669     2140     +471     
==========================================
+ Hits         1482     1904     +422     
- Misses        187      236      +49     

Flag	Coverage Δ
macos-latest	85.86% <71.08%> (-2.60%)	⬇️
ubuntu-latest	86.35% <81.25%> (-2.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
src/sources/generic.rs	75.63% <67.85%> (-3.25%)	⬇️
src/io.rs	78.09% <100.00%> (-4.46%)	⬇️
src/sources/signals.rs	82.29% <100.00%> (+1.83%)	⬆️
src/sys.rs	99.20% <100.00%> (+0.79%)	⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[notgull]

Ugh, looks like Github Actions is down.

[elinorbgr]

Alright, the CI is back. Also, even if git does not see any conflict, could you rebase on master for good measure?

[elinorbgr]

Okay, this looks good overall, but could you give more details about the NoIoDrop type that you introduced? Mostly what is its role and why is it needed? If possible as code/docs comments around this type, to make future maintainability easier.

[elinorbgr]

Perfect, thanks!