Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IFS compile warnings/errors #2673

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Oct 11, 2023

This PR improves the IFS ObjectBuffer implementation to fix 'hidden virtual method' warnings produced by more recent compilers. The class is just a helper/wrapper with a set of custom 'write' methods, so shouldn't have used inheritance in the first place.

Also fixes an 'uninitialised variable' warning in the Spiffs IFS library, identified by running IFS integration tests through valgrind.

@what-the-diff
Copy link

what-the-diff bot commented Oct 11, 2023

PR Summary

  • Submodule Update
    The submodule named Components/IFS was updated to a new commit state (36637f4e20), which means that the submodule code has been synchronized with the latest changes.

  • Code Refactoring in FileSystem.h
    The FileSystem.h file has undergone a small code modification. Specifically, the way spiffs fs is being declared has changed. Now it is being initialized with empty brackets spiffs fs{}, indicating a more cautious and competent way to deal with object creation and initialization.

mikee47 added 2 commits October 11, 2023 20:31
@slaff slaff merged commit ee881ef into SmingHub:develop Oct 12, 2023
36 checks passed
@mikee47 mikee47 deleted the fix/ifs-errors branch October 12, 2023 08:29
@slaff slaff mentioned this pull request Oct 24, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants