Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide workaround for 'dangling pointer' error/warning #2671

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Provide workaround for 'dangling pointer' error/warning #2671

merged 2 commits into from
Oct 12, 2023

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Oct 11, 2023

Sorts warnings for host builds as discussed in #2659.

@what-the-diff
Copy link

what-the-diff bot commented Oct 11, 2023

PR Summary

  • Addition of a new Function
    The developer has added a function named smg_return_local to the files FakePgmSpace.cpp and FakePgmSpace.h. This new function will likely contribute to improving the overall functionality of the application or software. However, without further context, it's difficult to outline specific benefits, as they depend on the purpose of this function in the broader program.

@slaff slaff added this to the 5.1.0 milestone Oct 11, 2023
@slaff
Copy link
Contributor

slaff commented Oct 11, 2023

@mikee47 run the coding style fixer and add the changes to this PR.

@mikee47 mikee47 force-pushed the fix/dangling-pointer-workaround branch 2 times, most recently from 29c90fc to e197356 Compare October 11, 2023 19:31
@mikee47 mikee47 force-pushed the fix/dangling-pointer-workaround branch from 73b6273 to 5b4812f Compare October 12, 2023 08:29
@slaff slaff merged commit a0585b2 into SmingHub:develop Oct 12, 2023
35 of 36 checks passed
mikee47 added a commit that referenced this pull request Oct 12, 2023
@mikee47
Revert "Provide workaround for 'dangling pointer' error/warning (#2671)"
2d4f0d6 
This reverts commit a0585b2.
mikee47 pushed a commit to mikee47/Sming that referenced this pull request Oct 12, 2023
Revert "Provide workaround for 'dangling pointer' error/warning (Smin…
25c96e6 
…gHub#2671)"

This reverts commit a0585b2.
@mikee47 mikee47 mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mikee47 @slaff