Update parameter on delete custom entity

Smile-SA · Jan 30, 2023 · f6b291f · f6b291f
1 parent f2341e4
commit f6b291f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,11 @@
 
 All notable changes to this project will be documented in this file.
 
+## [1.3.9] - 2023-01-30
+[1.3.9]: https://github.com/Smile-SA/magento2-module-custom-entity/compare/1.3.8...1.3.9
+
+- Update parameter on delete custom entity
+
 ## [1.3.8] - 2022-12-02
 [1.3.8]: https://github.com/Smile-SA/magento2-module-custom-entity/compare/1.3.7...1.3.8
 

diff --git a/Model/CustomEntityRepository.php b/Model/CustomEntityRepository.php
@@ -167,13 +167,12 @@ public function get($entityId, ?int $storeId = null, bool $forceReload = false):
     public function delete(CustomEntityInterface $entity): bool
     {
         try {
-            $entityId = $entity->getId();
-            $this->customEntityResource->delete($entityId);
+            $this->customEntityResource->delete($entity);
         } catch (\Exception $e) {
             throw new StateException(__('Cannot delete entity with id %1', $entity->getId()), $e);
         }
 
-        unset($this->instances[$entityId]);
+        unset($this->instances[$entity->getId()]);
 
         return true;
     }