Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cpu.Dockerfile #308

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Update cpu.Dockerfile #308

merged 1 commit into from
Jul 26, 2024

Conversation

Smartappli
Copy link
Owner

@Smartappli Smartappli commented Jul 26, 2024

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted the installation command for the llama-cpp-python package, removing server-specific dependencies, which may affect application functionality.
  • Chores
    • Minor modification in the Dockerfile to improve package installation by streamlining the command.

Copy link
Contributor

coderabbitai bot commented Jul 26, 2024

Caution

Review failed

The pull request is closed.

## Walkthrough
The recent change in the Dockerfile involves a simplification of the installation command for the `llama-cpp-python` package. By removing the `[server]` extra, the installation now focuses solely on the core package, excluding server-specific dependencies. This streamlining enhances the installation process without altering the overall structure and functionality of the Dockerfile.

## Changes

| Files                      | Change Summary                                                                                             |
|---------------------------|-----------------------------------------------------------------------------------------------------------|
| Docker/cpu/cpu.Dockerfile | Adjusted the installation command for `llama-cpp-python` by eliminating the `[server]` extra from the specification. |

## Poem
> In the code, a rabbit hops,  
> Simplifying as the server stops.  
> With `llama-cpp` now streamlined,  
> Dependencies trimmed, all aligned.  
> Hooray for clean installs, we cheer,  
> A lighter build, oh what a year! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

@Smartappli Smartappli merged commit b834f9d into master Jul 26, 2024
19 of 26 checks passed
Copy link

sonarcloud bot commented Jul 27, 2024

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 109b5e71
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (109b5e7) Report Missing Report Missing Report Missing
Head commit (419d0b2) 2127 1737 81.66%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#308) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant