-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slight modifications for jam.js support (partially fixes #79) #86
Conversation
…hough there's no way to configure it for jam compile at the moment - see caolan/jam#127 ). This commit keeps the dependencies included in the package, although we could update it to use jam-provided coppies of underscore and json2 (and possibly handlebars)
Of course.. now the auto linking works. |
…s to use. At this point, jam can compile with this plugin as long as you're using default hbs settings
I realized that without Handlebars.js at the top-level, the |
👍 |
So this is good to merge? |
Yep, I think so. I'm now using my branch instead of yours - the code's in QA right now and will be in production soon. There's room for improvements, but I think you could merge this in right now and publish the results to jam. I think the biggest issues is configuration - that will have to be fixed within jam. |
Slight modifications for jam.js support (partially fixes #79)
What is the setup to use in package.json ? for now i just add this Thanks for your support |
I'm not a jam user, but I'd bet you can just copy the |
@mic0331 that's where it's trying to load your language file for i18n. Unfortunately there's no way to disable that in jam, it's just set to whatever the default is (on, in this case). For the moment, you just have to create a
@SlexAxton do you want to try and handle this before jam gets fixed to support configuration? I can think of a few possible solutions:
I honestly like option 3 the best, but it's also the most work. What do you think? |
I'm cool with option 3, but will take more time. Until then, option 1 seems the best, but ruins the 'demo' part of the repo. So maybe number 2 is better? Wanna pull request? |
I'll try and get # 2 done today, I'm just a little squeezed for time. |
I told jam the package name is "hbs" so that the plugin is hbs!, and I rewrote the dependencies to use relative urls. The reason It's only a partial fix because there's currently no way to configure it for jam compile at the moment - see caolan/jam#127
(And, of course, you'd need to create a jam account and publish it.)
I kept the dependencies included in the package, although we could update it to use jam-provided coppies of underscore and json2 (and possibly handlebars) if we wanted.