-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
extracting randomizer; added extensive percentage testing;
- Loading branch information
Oleg Kulik
committed
Mar 22, 2018
1 parent
8ba30c3
commit 5485cde
Showing
11 changed files
with
156 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <?php | ||
| declare(strict_types=1); | ||
|
|
||
| namespace SlayerBirden\DFCodeGeneration\Generator\Tests; | ||
|
|
||
| class NullValuesRandomizer | ||
| { | ||
| /** | ||
| * @var float | ||
| */ | ||
| private $probabilityOfFilledNull; | ||
|
|
||
| public function __construct(float $probabilityOfFilledNull) | ||
| { | ||
| $this->probabilityOfFilledNull = $probabilityOfFilledNull; | ||
| } | ||
|
|
||
| /** | ||
| * @return bool | ||
| */ | ||
| public function ifShouldWrite(): bool | ||
| { | ||
| return rand(0,100)/100 < $this->probabilityOfFilledNull; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| <?php | ||
| declare(strict_types=1); | ||
|
|
||
| namespace SlayerBirden\DFCodeGeneration\Generator\Tests; | ||
|
|
||
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class NullValuesRandomizerTest extends TestCase | ||
| { | ||
| /** | ||
| * @dataProvider percentageProvider | ||
| * | ||
| * @param float $percentage | ||
| */ | ||
| public function testPercentage(float $percentage) | ||
| { | ||
| $randomizer = new NullValuesRandomizer($percentage); | ||
| $hits = 0; | ||
| $total = 1000000; | ||
| for ($i = 0; $i < $total; ++$i) { | ||
| $randomizer->ifShouldWrite() ? ++$hits : null; | ||
| } | ||
|
|
||
| $expected = (int)($percentage * 100); | ||
| $actual = round($hits / $total * 100); | ||
|
|
||
| $this->assertThat($actual, new RangeConstraint($expected - 1, $expected + 1)); | ||
| } | ||
|
|
||
| public function testThatZeroNeverCalled() | ||
| { | ||
| $randomizer = new NullValuesRandomizer(.0); | ||
|
|
||
| $hits = 0; | ||
| for ($i = 0; $i < 1000000; ++$i) { | ||
| $randomizer->ifShouldWrite() ? ++$hits : null; | ||
| } | ||
|
|
||
| $this->assertSame(0, $hits); | ||
| } | ||
|
|
||
| public function percentageProvider(): array | ||
| { | ||
| return [ | ||
| [.1], | ||
| [.5], | ||
| [.0], | ||
| ]; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| <?php | ||
| declare(strict_types=1); | ||
|
|
||
| namespace SlayerBirden\DFCodeGeneration\Generator\Tests; | ||
|
|
||
| use PHPUnit\Framework\Constraint\Constraint; | ||
|
|
||
| class RangeConstraint extends Constraint | ||
| { | ||
| /** | ||
| * @var int | ||
| */ | ||
| private $from; | ||
| /** | ||
| * @var int | ||
| */ | ||
| private $to; | ||
|
|
||
| public function __construct(int $from, int $to) | ||
| { | ||
| parent::__construct(); | ||
| $this->from = $from; | ||
| $this->to = $to; | ||
| } | ||
|
|
||
| /** | ||
| * @inheritdoc | ||
| */ | ||
| public function toString(): string | ||
| { | ||
| return 'in range'; | ||
| } | ||
|
|
||
| /** | ||
| * @inheritdoc | ||
| */ | ||
| protected function matches($other): bool | ||
| { | ||
| return $other >= $this->from && $other <= $this->to; | ||
| } | ||
|
|
||
| /** | ||
| * @inheritdoc | ||
| */ | ||
| protected function failureDescription($other): string | ||
| { | ||
| return \sprintf( | ||
| '%s is not in range between %s and %s', | ||
| $this->exporter->shortenedExport($other), | ||
| $this->from, | ||
| $this->to | ||
| ); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters