Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix check user goal #993

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix check user goal #993

merged 1 commit into from
Oct 17, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Oct 17, 2024

Important

Fixes key check in check_user_goal_success() in agent.py by changing reasoning to thoughts in verification_response.

  • Behavior:
    • Fixes key check in check_user_goal_success() in agent.py by changing reasoning to thoughts in verification_response.
    • Updates CompleteAction instantiation to use verification_response["thoughts"] instead of verification_response["reasoning"].

This description was created by Ellipsis for df96bf3. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to df96bf3 in 12 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/agent.py:894
  • Draft comment:
    Ensure that 'thoughts' is the correct key in the verification_response. If 'reasoning' was previously used, verify that 'thoughts' is now the expected key in all relevant parts of the codebase.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the key from 'reasoning' to 'thoughts' in the verification_response dictionary. This change is consistent across the code, but we need to ensure that 'thoughts' is the correct key to use.

Workflow ID: wflow_X1GMeBjAU3jSYKCa


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit c0113a9 into main Oct 17, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/fix-check-user-goal branch October 17, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant