improve check user goal by doing zero prompt shot with 'step by step' thinking #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Simplifies JSON response format and emphasizes step-by-step reasoning in `check-user-goal.j2`. > > - **Prompt Template Update**: > - In `check-user-goal.j2`, renamed `state` to `page_info` and `reasoning` to `thoughts`. > - Removed examples and redundant instructions, emphasizing step-by-step reasoning. > - JSON response format simplified to include only `page_info`, `thoughts`, and `user_goal_achieved`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 36323eb15f1274c216981d381e53d249367eed66. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 64d45a2 in 8 seconds
More details
- Looked at
35lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/prompts/skyvern/check-user-goal.j2:1
- Draft comment:
Typo in the first line: "Your are here" should be "You are here". - Reason this comment was not posted:
Confidence changes required:50%
The prompt template has a typo in the first line that should be corrected for clarity.
Workflow ID: wflow_pj1umjTbs8e817y4
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 64d45a2 in 8 seconds
More details
- Looked at
35lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/prompts/skyvern/check-user-goal.j2:1
- Draft comment:
Typo in the first line: "Your are here" should be "You are here". - Reason this comment was not posted:
Confidence changes required:10%
The PR description mentions renaming 'state' to 'page_info' and 'reasoning' to 'thoughts', which is correctly reflected in the code. However, there is a typo in the first line that should be corrected for clarity.
Workflow ID: wflow_eB8jXYsopijutyUL
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Simplifies JSON response format and emphasizes step-by-step reasoning in
check-user-goal.j2.check-user-goal.j2, renamedstatetopage_infoandreasoningtothoughts.page_info,thoughts, anduser_goal_achieved.This description was created by
for 64d45a2. It will automatically update as commits are pushed.