update user goal complete prompt to have more chain of thoughts #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Enhance user goal completion and action extraction prompts by updating JSON structure and descriptions in `check-user-goal.j2` and `extract-action.j2`. > > - **Behavior**: > - Updated `check-user-goal.j2` to include a `state` field in JSON output, describing page state and user progress. > - Enhanced `reasoning` field in `check-user-goal.j2` for precise explanations using site information. > - Modified `extract-action.j2` to clarify use of user details for filling values and ensuring valid JSON output. > - **Examples**: > - Updated examples in `check-user-goal.j2` to reflect new `state` and `reasoning` fields. > - **Misc**: > - Minor text adjustments in `extract-action.j2` for clarity. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 72b81f02deede3de5420d6c5ce1dad0d37a43fcc. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Enhance user goal completion and action extraction prompts by updating JSON structure and descriptions in `check-user-goal.j2` and `extract-action.j2`. > > - **Behavior**: > - Updated `check-user-goal.j2` to include a `state` field in JSON output, describing page state and user progress. > - Enhanced `reasoning` field in `check-user-goal.j2` for precise explanations using site information. > - Modified `extract-action.j2` to clarify use of user details for filling values and ensuring valid JSON output. > - **Examples**: > - Updated examples in `check-user-goal.j2` to reflect new `state` and `reasoning` fields. > - **Misc**: > - Minor text adjustments in `extract-action.j2` for clarity. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 72b81f02deede3de5420d6c5ce1dad0d37a43fcc. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 9827e4c in 8 seconds
More details
- Looked at
42lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNodeDisplayModeSwitch.tsx:4
- Draft comment:
Consider adding PropTypes validation to ensure the correct types are passed as props. - Reason this comment was not posted:
Confidence changes required:50%
The code is missing PropTypes validation, which is a best practice for React components to ensure the correct types are passed as props.
Workflow ID: wflow_RvgLcA2IShjBfFYl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 9827e4c in 19 seconds
More details
- Looked at
98lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. skyvern/forge/prompts/skyvern/check-user-goal.j2:1
- Draft comment:
Typo: Replace 'Your are' with 'You are'.
You are here to help the user determine if the user has completed their goal on the web. Use the content of the elements parsed from the page, the user goal and user details to determine whether the user goal has been completed or not.
- Reason this comment was not posted:
Confidence changes required:10%
The word 'Your' is misspelled as 'Your are' instead of 'You are'.
2. skyvern/forge/prompts/skyvern/check-user-goal.j2:6
- Draft comment:
Typo: Replace 'accoriding' with 'according'.
"state": str, // Describe the state of the page according to the user goal. Be precise and talk about what progress the user made, and what the next step is to move towards the user goal if any.
- Reason this comment was not posted:
Confidence changes required:10%
The word 'according' is misspelled as 'accoriding'.
3. skyvern/forge/prompts/skyvern/check-user-goal.j2:8
- Draft comment:
JSON does not support comments. Consider removing comments or documenting them outside the JSON block. This issue is also present on lines 6 and 7. - Reason this comment was not posted:
Confidence changes required:50%
The comment format in JSON is incorrect as JSON does not support comments. This is a common issue in multiple places.
Workflow ID: wflow_kmJ3Homy7uGFrr2c
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
…skNodeDisplayModeSwitch.tsx
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on e11dbcb in 8 seconds
More details
- Looked at
40lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_rGRtMMZKyy1cagHG
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Enhance user goal completion prompts with detailed state and reasoning fields, and add a frontend component for display mode switching.
check-user-goal.j2to includestatefield in JSON output, describing page state and user progress.reasoningfield incheck-user-goal.j2for precise explanations using site information.extract-action.j2to clarify use of user details for filling values and ensuring valid JSON output.check-user-goal.j2to reflect newstateandreasoningfields.TaskNodeDisplayModeSwitchcomponent inTaskNodeDisplayModeSwitch.tsxfor switching between basic and advanced display modes.This description was created by
for e11dbcb. It will automatically update as commits are pushed.