Task block changes #989
Merged
Task block changes #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Consolidated `TaskNode` UI by removing display mode switch, adding `cacheActions`, and restructuring settings into accordion sections. > > - **Behavior**: > - Removed `TaskNodeDisplayModeSwitch` and its logic from `TaskNode.tsx`, consolidating UI into a single accordion view. > - Added `cacheActions` property to `TaskNode` inputs and data model. > - **UI Components**: > - Replaced display mode switch with accordion sections for content, extraction, and advanced settings in `TaskNode.tsx`. > - Added `Separator` components for better UI separation. > - **Types**: > - Removed `TaskNodeDisplayMode` type from `types.ts`. > - Updated `helpTooltipContent` in `types.ts` to include `cacheActions` and `continueOnFailure`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 683f09228de582db8ec05cf5395afd85e9cbcc87. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to a11a3c0 in 16 seconds
More details
- Looked at
881lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/types.ts:74
- Draft comment:
TheTaskNodeDisplayModetype is no longer used and can be removed to clean up the code. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_rh9ZGBysM2cXEsqA
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on a11a3c0 in 17 seconds
More details
- Looked at
879lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/types.ts:74
- Draft comment:
TheTaskNodeDisplayModetype is no longer used and can be removed to clean up the code. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_nMeZj5GCFQGWhybQ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Consolidated
TaskNodeUI by removing display mode switch, addingcacheActions, and restructuring settings into accordion sections.TaskNodeDisplayModeSwitchand its logic fromTaskNode.tsx, consolidating UI into a single accordion view.cacheActionsproperty toTaskNodeinputs and data model.TaskNode.tsx.Separatorcomponents for better UI separation.TaskNodeDisplayModetype fromtypes.ts.helpTooltipContentintypes.tsto includecacheActionsandcontinueOnFailure.This description was created by
for a11a3c0. It will automatically update as commits are pushed.