Export workflow #987
Export workflow #987
Conversation
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add export functionality for workflows in JSON and YAML formats in `WorkflowActions.tsx`. > > - **Export Feature**: > - Added `handleExport` function in `WorkflowActions.tsx` to export workflows as JSON or YAML. > - Introduced `downloadFile` function in `WorkflowActions.tsx` to facilitate file downloads. > - Updated `DropdownMenu` in `WorkflowActions.tsx` to include export options. > - **Conversion Logic**: > - Modified `convert` function in `workflowEditorUtils.ts` to retain original workflow title during export. > - **UI Components**: > - Added `DownloadIcon` to export options in `WorkflowActions.tsx`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for e09d41cbc2741afff9aded8ecac5c4510a3515e8. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 32100b8 in 34 seconds
More details
- Looked at
145lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_gOnASNn7FJuSe32B
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| const element = document.createElement("a"); | ||
| element.setAttribute( | ||
| "href", | ||
| "data:text/plain;charset=utf-8," + encodeURIComponent(contents), |
There was a problem hiding this comment.
Consider using application/json as the MIME type for JSON files instead of text/plain. This ensures better compatibility and handling by browsers and other tools.
| "data:text/plain;charset=utf-8," + encodeURIComponent(contents), | |
| "data:application/json;charset=utf-8," + encodeURIComponent(contents), |
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 32100b8 in 34 seconds
More details
- Looked at
145lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:1072
- Draft comment:
The change to retain the original workflow title during export is correct and aligns with the PR description. - Reason this comment was not posted:
Confidence changes required:0%
Theconvertfunction inworkflowEditorUtils.tsis used to convert workflows for export. The change in the PR ensures the original title is retained during export, which aligns with the PR description.
Workflow ID: wflow_qjUSYppx4bDJT5PN
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| const element = document.createElement("a"); | ||
| element.setAttribute( | ||
| "href", | ||
| "data:text/plain;charset=utf-8," + encodeURIComponent(contents), |
There was a problem hiding this comment.
Consider using application/json as the MIME type for JSON files instead of text/plain. This ensures better compatibility and handling by browsers and other tools.
Important
Add export functionality for workflows in JSON and YAML formats in
WorkflowActions.tsx.handleExportfunction inWorkflowActions.tsxto export workflows as JSON or YAML.downloadFilefunction inWorkflowActions.tsxto facilitate file downloads.DropdownMenuinWorkflowActions.tsxto include export options.convertfunction inworkflowEditorUtils.tsto retain original workflow title during export.DownloadIconto export options inWorkflowActions.tsx.This description was created by
for 32100b8. It will automatically update as commits are pushed.