handle continue on failure for loop node #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add `continue_on_failure` property to `for_loop` block in `getWorkflowBlocksUtil()` to handle loop nodes that should continue on failure. > > - **Behavior**: > - Adds `continue_on_failure` property to `for_loop` block in `getWorkflowBlocksUtil()` in `workflowEditorUtils.ts` to handle loop nodes that should continue on failure. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 6c13cb1c16263559ec0581b0cfcf27a36717aa42. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 66c3428 in 9 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:613
- Draft comment:
Ensurecontinue_on_failureis correctly handled in all relevant functions, such asconvertToNodeandgetWorkflowBlock, to maintain consistency across the codebase. - Reason this comment was not posted:
Confidence changes required:50%
The PR adds a new propertycontinue_on_failureto thefor_loopblock in thegetWorkflowBlocksUtilfunction. This change is consistent with the PR description and seems to be correctly implemented. However, I need to ensure that thecontinue_on_failureproperty is handled correctly throughout the codebase.
Workflow ID: wflow_4BdGq0xijXN8ReEm
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 66c3428 in 13 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:613
- Draft comment:
EnsurecontinueOnFailureis correctly handled in all related functions, such asconvertToNodeandgetWorkflowBlock, to maintain consistency with the newcontinue_on_failureproperty. - Reason this comment was not posted:
Confidence changes required:50%
The PR adds a new propertycontinue_on_failureto thefor_loopblock in thegetWorkflowBlocksUtilfunction. This change is consistent with the PR description and seems to be correctly implemented. However, I need to ensure that thecontinue_on_failureproperty is handled correctly throughout the codebase, especially in related functions likeconvertToNodeandgetWorkflowBlock.
Workflow ID: wflow_ob52BnoWuPwGpFDu
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
continue_on_failureproperty tofor_loopblock ingetWorkflowBlocksUtil()to handle loop nodes that should continue on failure.continue_on_failureproperty tofor_loopblock ingetWorkflowBlocksUtil()inworkflowEditorUtils.tsto handle loop nodes that should continue on failure.This description was created by
for 66c3428. It will automatically update as commits are pushed.