Add continue on failure as passthrough and cache_actions property #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add `continueOnFailure` and `cacheActions` properties to node types and update workflow editor utilities for enhanced failure handling and action caching. > > - **Node Types**: > - Introduce `NodeBaseData` type with `label` and `continueOnFailure` properties in `types.ts`. > - Extend `NodeBaseData` in `CodeBlockNodeData`, `DownloadNodeData`, `FileParserNodeData`, `LoopNodeData`, `SendEmailNodeData`, `TaskNodeData`, `TextPromptNodeData`, and `UploadNodeData`. > - Add `continueOnFailure: false` to default data in `CodeBlockNode`, `DownloadNode`, `FileParserNode`, `LoopNode`, `SendEmailNode`, `TaskNode`, `TextPromptNode`, and `UploadNode`. > - Add `cacheActions: false` to `TaskNodeData` and default data in `TaskNode`. > - **Workflow Editor Utils**: > - Update `convertToNode()` and `getWorkflowBlock()` in `workflowEditorUtils.ts` to handle `continueOnFailure` and `cacheActions` properties. > - Use `NodeBaseData` for common node data handling in `convertToNode()`. > - **Types**: > - Add `cache_actions` to `TaskBlock` in `workflowTypes.ts` and `TaskBlockYAML` in `workflowYamlTypes.ts`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 9c9dae06a80637bdd1e10e6b686fefef57cd4719. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ca4d80b in 24 seconds
More details
- Looked at
507lines of code in12files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TextPromptNode/types.ts:5
- Draft comment:
Thelabelproperty is already included inNodeBaseDataand should not be redefined here. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_sC6kMYtmnwql7U6T
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ca4d80b in 25 seconds
More details
- Looked at
507lines of code in12files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TextPromptNode/types.ts:5
- Draft comment:
Thelabelproperty is already included inNodeBaseDataand should not be redefined here.
- Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_jdxLDWm46G85JtQz
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
continueOnFailureandcacheActionsproperties to node types and update workflow editor utilities for enhanced failure handling and action caching.NodeBaseDatatype withlabelandcontinueOnFailureproperties intypes.ts.NodeBaseDatainCodeBlockNodeData,DownloadNodeData,FileParserNodeData,LoopNodeData,SendEmailNodeData,TaskNodeData,TextPromptNodeData, andUploadNodeData.continueOnFailure: falseto default data inCodeBlockNode,DownloadNode,FileParserNode,LoopNode,SendEmailNode,TaskNode,TextPromptNode, andUploadNode.cacheActions: falsetoTaskNodeDataand default data inTaskNode.convertToNode()andgetWorkflowBlock()inworkflowEditorUtils.tsto handlecontinueOnFailureandcacheActionsproperties.NodeBaseDatafor common node data handling inconvertToNode().cache_actionstoTaskBlockinworkflowTypes.tsandTaskBlockYAMLinworkflowYamlTypes.ts.This description was created by
for ca4d80b. It will automatically update as commits are pushed.