add continue on failure in task block

[wintonzheng]

Important

Add continueOnFailure feature to TaskNode to allow tasks to continue on failure, updating UI, types, and conversion utilities.

• Behavior:
  • Add continueOnFailure property to TaskNode in TaskNode.tsx to allow tasks to continue on failure.
  • Update UI in TaskNode.tsx to include a switch for continueOnFailure.
• Types:
  • Add continueOnFailure to TaskNodeData and taskNodeDefaultData in types.ts.
• Utils:
  • Update convertToNode() and getWorkflowBlock() in workflowEditorUtils.ts to handle continueOnFailure property.
• Misc:
  • Remove CachedActionPlanError class from exceptions.py.
  • Remove retrieve_action_plan() and related functions from agent.py and caching.py.
  • Rename calculate_sha256_for_file() to calculate_sha256() in files.py.

^{This description was created by for 6b74d28. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Incremental review on 6b74d28 in 26 seconds

More details

• Looked at 79 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx:342

• Draft comment:
  Consider adding a HelpTooltip for Continue on Failure to provide users with more context about this option.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The continueOnFailure property is being added to the TaskNode component and its related types and utilities. However, there is a missing tooltip for this new property in the UI, which could help users understand its purpose.

Workflow ID: wflow_juTrzRVJ0kbb2Rf8

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 6b74d28 in 1 minute and 1 seconds

More details

• Looked at 1357 lines of code in 21 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx:73

• Draft comment:
  Consider providing a default value for continueOnFailure in the inputs object to avoid potential undefined behavior if data.continueOnFailure is not set.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The comment is relevant to the change made in the diff, which added continueOnFailure to the inputs object. The suggestion to provide a default value is actionable and could prevent potential issues if data.continueOnFailure is undefined. This aligns with the rule that suggests code quality refactors are good if they are actionable and clear.
  The code might handle undefined values for continueOnFailure elsewhere, making the comment unnecessary. Without seeing the entire codebase, it's hard to confirm if this is the case.
  The comment is about a potential issue directly related to the change made in the diff. Without evidence that the issue is already handled, it's reasonable to consider the comment valid.
  Keep the comment as it suggests an actionable improvement related to the change made in the diff.

2. skyvern/forge/sdk/workflow/service.py:1128

• Draft comment:
  The addition of continueOnFailure to the TaskBlock and other block types is consistent with the PR description and ensures that the property is handled across different block types.
• Reason this comment was not posted:
  Confidence changes required: 30%
  The continueOnFailure property is being added to multiple block types in block_yaml_to_block function. This is consistent with the PR description and ensures that the property is handled across different block types.

3. skyvern/webeye/actions/actions.py:162

• Draft comment:
  The parse_action function correctly handles the continueOnFailure property by mapping it to the appropriate action types, ensuring its utilization during action parsing.
• Reason this comment was not posted:
  Confidence changes required: 30%
  The parse_action function in actions.py is handling the continueOnFailure property correctly by mapping it to the appropriate action types. This ensures that the property is utilized during action parsing.

Workflow ID: wflow_TIJy0UmFOzOFucLo

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.