Add help to URL field of task block #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add `HelpTooltip` to the URL field in `TaskNode.tsx` and update `helpTooltipContent` in `types.ts`. > > - **UI Enhancements**: > - Added `HelpTooltip` to the URL field in `TaskNode.tsx` for both basic and advanced content sections. > - **Content Updates**: > - Updated `helpTooltipContent` in `types.ts` to include a description for the `url` field. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for b04973492d2376cdae3ae85b5d5bc0ba4ab75418. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to e56225a in 9 seconds
More details
- Looked at
41lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx:95
- Draft comment:
EnsurehelpTooltipContent["url"]is defined and correctly updated intypes.ts. - Reason this comment was not posted:
Confidence changes required:50%
The PR adds a HelpTooltip to the URL field, which is a UI enhancement. The implementation seems correct, but I need to ensure that the helpTooltipContent is correctly updated and used.
Workflow ID: wflow_LvFDmzpXw0pGwbVl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on e56225a in 9 seconds
More details
- Looked at
41lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/TaskNode/TaskNode.tsx:95
- Draft comment:
Ensure thathelpTooltipContent["url"]is defined and correctly imported fromtypes.ts. This applies to other instances whereHelpTooltipis used. - Reason this comment was not posted:
Confidence changes required:33%
The PR adds a HelpTooltip to the URL field in both basic and advanced sections, which is consistent with the description. The tooltip content is also updated in types.ts. The changes are straightforward and align with the PR intent.
Workflow ID: wflow_gnEk5ewhTxUwyC4R
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
HelpTooltipto the URL field inTaskNode.tsxand updatehelpTooltipContentintypes.tsfor enhanced UI and content clarity.HelpTooltipto the URL field inTaskNode.tsxfor both basic and advanced content sections.helpTooltipContentintypes.tsto include a description for theurlfield.This description was created by
for e56225a. It will automatically update as commits are pushed.