-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update loop node styles #972
Conversation
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Update `LoopNode` styling and layout calculations to use pixel units instead of rem. > > - **Styling**: > - Update `LoopNode.tsx` to change width from `60rem` to `600px` and border radius from `rounded-md` to `rounded-xl`. > - **Layout Calculation**: > - Update `workflowEditorUtils.ts` to change `loopNodeWidth` from `60 * 16` (rem) to `600` (px) in `layout()` function. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for ade9ecbc00e8579c020b5d8a47261a85b9ccea01. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 2a8721e in 21 seconds
More details
- Looked at
109
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/LoopNode/LoopNode.tsx:80
- Draft comment:
The inner div still usesrounded-lg
for border radius. Consider updating it torounded-xl
to match the PR description. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_aWRWI4bXM6p1TCaI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 2a8721e in 33 seconds
More details
- Looked at
109
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
5
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/LoopNode/LoopNode.tsx:80
- Draft comment:
The width change from60rem
to600px
is correctly implemented as per the PR description. - Reason this comment was not posted:
Confidence changes required:0%
The PR description mentions changing the width from60rem
to600px
inLoopNode.tsx
. This change is correctly reflected in the code.
2. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:102
- Draft comment:
The change from60 * 16
to600
forloopNodeWidth
is correctly implemented as per the PR description. - Reason this comment was not posted:
Confidence changes required:0%
The PR description mentions changing theloopNodeWidth
from60 * 16
to600
inworkflowEditorUtils.ts
. This change is correctly reflected in the code.
3. skyvern-frontend/src/routes/tasks/create/TaskTemplates.tsx:40
- Draft comment:
Thecontact_us_forms
template has been removed. Ensure this change is intentional as it is not mentioned in the PR description. - Reason this comment was not posted:
Confidence changes required:50%
The PR description does not mention any changes to the task templates, but there are changes inTaskTemplates.tsx
andsampleTaskData.ts
related to the removal ofcontact_us_forms
. This should be noted as it might be an unintended change.
4. skyvern-frontend/src/routes/tasks/data/sampleTaskData.ts:78
- Draft comment:
Thecontact_us_forms
data has been removed. Ensure this change is intentional as it is not mentioned in the PR description. - Reason this comment was not posted:
Confidence changes required:50%
The removal ofcontact_us_forms
is also reflected insampleTaskData.ts
. This should be noted as it might be an unintended change.
5. skyvern-frontend/src/routes/tasks/types.ts:10
- Draft comment:
Thecontact_us_forms
type has been removed. Ensure this change is intentional as it is not mentioned in the PR description. - Reason this comment was not posted:
Confidence changes required:50%
The removal ofcontact_us_forms
is also reflected intypes.ts
. This should be noted as it might be an unintended change.
Workflow ID: wflow_hvuj5wIoELM6HOiI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on e828bea in 21 seconds
More details
- Looked at
81
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/types.ts:10
- Draft comment:
Thecontact_us_forms
task template should be removed from thesampleCases
array as per the PR description. - Reason this comment was not posted:
Comment did not seem useful.
2. skyvern-frontend/src/routes/tasks/create/TaskTemplates.tsx:40
- Draft comment:
Thecontact_us_forms
task template should be removed from thetemplateSamples
object as per the PR description. - Reason this comment was not posted:
Comment did not seem useful.
3. skyvern-frontend/src/routes/tasks/data/sampleTaskData.ts:81
- Draft comment:
Thecontact_us_forms
task template should be removed from thesampleTaskData.ts
file as per the PR description. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_yKWnvZBO3acqNJ8x
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Update
LoopNode
styling and removecontact_us_forms
task template.LoopNode.tsx
to change width from60rem
to600px
and border radius fromrounded-md
torounded-xl
.workflowEditorUtils.ts
to changeloopNodeWidth
from60 * 16
(rem) to600
(px) inlayout()
function.California EDD
toCalifornia_EDD
andBCI Seguros
tobci_seguros
inTaskTemplates.tsx
.contact_us_forms
task fromsampleTaskData.ts
andtypes.ts
.This description was created by
for e828bea. It will automatically update as commits are pushed.