Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loop node styles #972

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Update loop node styles #972

merged 2 commits into from
Oct 15, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Oct 15, 2024

Important

Update LoopNode styling and remove contact_us_forms task template.

  • Styling:
    • Update LoopNode.tsx to change width from 60rem to 600px and border radius from rounded-md to rounded-xl.
  • Layout Calculation:
    • Update workflowEditorUtils.ts to change loopNodeWidth from 60 * 16 (rem) to 600 (px) in layout() function.
  • Task Templates:
    • Rename California EDD to California_EDD and BCI Seguros to bci_seguros in TaskTemplates.tsx.
    • Remove contact_us_forms task from sampleTaskData.ts and types.ts.

This description was created by Ellipsis for e828bea. It will automatically update as commits are pushed.

…src/'

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Update `LoopNode` styling and layout calculations to use pixel units instead of rem.
>
>   - **Styling**:
>     - Update `LoopNode.tsx` to change width from `60rem` to `600px` and border radius from `rounded-md` to `rounded-xl`.
>   - **Layout Calculation**:
>     - Update `workflowEditorUtils.ts` to change `loopNodeWidth` from `60 * 16` (rem) to `600` (px) in `layout()` function.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for ade9ecbc00e8579c020b5d8a47261a85b9ccea01. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2a8721e in 21 seconds

More details
  • Looked at 109 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/LoopNode/LoopNode.tsx:80
  • Draft comment:
    The inner div still uses rounded-lg for border radius. Consider updating it to rounded-xl to match the PR description.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_aWRWI4bXM6p1TCaI


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 2a8721e in 33 seconds

More details
  • Looked at 109 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/LoopNode/LoopNode.tsx:80
  • Draft comment:
    The width change from 60rem to 600px is correctly implemented as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR description mentions changing the width from 60rem to 600px in LoopNode.tsx. This change is correctly reflected in the code.
2. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:102
  • Draft comment:
    The change from 60 * 16 to 600 for loopNodeWidth is correctly implemented as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR description mentions changing the loopNodeWidth from 60 * 16 to 600 in workflowEditorUtils.ts. This change is correctly reflected in the code.
3. skyvern-frontend/src/routes/tasks/create/TaskTemplates.tsx:40
  • Draft comment:
    The contact_us_forms template has been removed. Ensure this change is intentional as it is not mentioned in the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR description does not mention any changes to the task templates, but there are changes in TaskTemplates.tsx and sampleTaskData.ts related to the removal of contact_us_forms. This should be noted as it might be an unintended change.
4. skyvern-frontend/src/routes/tasks/data/sampleTaskData.ts:78
  • Draft comment:
    The contact_us_forms data has been removed. Ensure this change is intentional as it is not mentioned in the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The removal of contact_us_forms is also reflected in sampleTaskData.ts. This should be noted as it might be an unintended change.
5. skyvern-frontend/src/routes/tasks/types.ts:10
  • Draft comment:
    The contact_us_forms type has been removed. Ensure this change is intentional as it is not mentioned in the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The removal of contact_us_forms is also reflected in types.ts. This should be noted as it might be an unintended change.

Workflow ID: wflow_hvuj5wIoELM6HOiI


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on e828bea in 21 seconds

More details
  • Looked at 81 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/types.ts:10
  • Draft comment:
    The contact_us_forms task template should be removed from the sampleCases array as per the PR description.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. skyvern-frontend/src/routes/tasks/create/TaskTemplates.tsx:40
  • Draft comment:
    The contact_us_forms task template should be removed from the templateSamples object as per the PR description.
  • Reason this comment was not posted:
    Comment did not seem useful.
3. skyvern-frontend/src/routes/tasks/data/sampleTaskData.ts:81
  • Draft comment:
    The contact_us_forms task template should be removed from the sampleTaskData.ts file as per the PR description.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_yKWnvZBO3acqNJ8x


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit afb39da into main Oct 15, 2024
2 checks passed
@msalihaltun msalihaltun deleted the salih/update-loop-node-styles branch October 15, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants