Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change workflow run page to show stream with current task #971

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Oct 14, 2024

Important

Enhance WorkflowRun.tsx to display current task details, improve UI, and make onChange optional in CodeEditor.tsx.

  • Behavior:
    • Display current running task details (ID, URL, Status, Created) in WorkflowRun.tsx.
    • Show task details only if the workflow is not finalized and a task is running.
  • UI Enhancements:
    • Add rounded corners to stream and task detail containers in getStream() in WorkflowRun.tsx.
    • Update task table headers and task filtering to exclude the current running task in WorkflowRun.tsx.
  • Logic:
    • Introduce currentRunningTask to identify the currently running task from workflowTasks in WorkflowRun.tsx.
  • Misc:
    • Make onChange prop optional in CodeEditor.tsx.
    • Add timeFormatWithShortDate function in timeFormat.ts.

This description was created by Ellipsis for 7ee18ce. It will automatically update as commits are pushed.

…src/'

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Enhance `WorkflowRun.tsx` to display current task details, improve UI, and make `onChange` optional in `CodeEditor.tsx`.
>
>   - **Behavior**:
>     - Display current running task details (ID, URL, Status, Created) in `WorkflowRun.tsx`.
>     - Show task details only if the workflow is not finalized and a task is running.
>   - **UI Enhancements**:
>     - Add rounded corners to stream and task detail containers in `getStream()` in `WorkflowRun.tsx`.
>     - Update task table headers and task filtering to exclude the current running task in `WorkflowRun.tsx`.
>   - **Logic**:
>     - Introduce `currentRunningTask` to identify the currently running task from `workflowTasks` in `WorkflowRun.tsx`.
>   - **Misc**:
>     - Make `onChange` prop optional in `CodeEditor.tsx`.
>     - Add `timeFormatWithShortDate` function in `timeFormat.ts`.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 09562e309283c005c1bde0da3aa55f26dabfcd62. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on dc18785 in 22 seconds

More details
  • Looked at 449 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/components/CodeEditor.tsx:9
  • Draft comment:
    The onChange prop is now optional, which aligns with the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR description mentions making onChange optional in CodeEditor.tsx. The change has been made correctly by adding a ? to the onChange prop in the Props type definition.
2. skyvern-frontend/src/util/timeFormat.ts:13
  • Draft comment:
    The timeFormatWithShortDate function is correctly implemented and exported.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR description mentions adding a new function timeFormatWithShortDate in timeFormat.ts. The function is correctly implemented and exported.
3. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:404
  • Draft comment:
    The current running task is correctly excluded from the task table using a filter method.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR description mentions excluding the current running task from the task table in WorkflowRun.tsx. The filter method is correctly applied to exclude the current running task.
4. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:326
  • Draft comment:
    Current task details are correctly displayed when a task is running and the workflow is not finalized.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR description mentions displaying current task details in WorkflowRun.tsx. The implementation correctly displays task details when a task is running and the workflow is not finalized.

Workflow ID: wflow_ywBBTVnSvDNxXVCm


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to dc18785 in 25 seconds

More details
  • Looked at 449 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/components/CodeEditor.tsx:9
  • Draft comment:
    The onChange prop is now optional, which aligns with the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR description mentions making the onChange prop optional in CodeEditor.tsx. The change has been made correctly by adding a ? to the onChange prop type definition.
2. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:204
  • Draft comment:
    Added rounded-md class for rounded corners, as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR description mentions adding rounded corners to stream and task detail containers in getStream() in WorkflowRun.tsx. The changes have been made correctly by adding rounded-md class to the relevant divs.
3. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:404
  • Draft comment:
    Filtered out the current running task from the task list, as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR description mentions updating task table headers and task filtering to exclude the current running task in WorkflowRun.tsx. The changes have been made correctly by filtering out the current running task and updating the headers.
4. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:125
  • Draft comment:
    Introduced currentRunningTask to identify the currently running task, as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR description mentions introducing currentRunningTask to identify the currently running task from workflowTasks in WorkflowRun.tsx. The changes have been made correctly by using find to get the running task.
5. skyvern-frontend/src/util/timeFormat.ts:13
  • Draft comment:
    Added timeFormatWithShortDate function, as per the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR description mentions adding a timeFormatWithShortDate function in timeFormat.ts. The function has been added correctly and is exported.

Workflow ID: wflow_ndq8dbPXuwY99ZQM


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 7ee18ce in 11 seconds

More details
  • Looked at 81 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/types.ts:10
  • Draft comment:
    The addition of 'contact_us_forms' to the sampleCases array is consistent with the new task template added in other files. This change is correct and aligns with the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR adds a new sample case 'contact_us_forms' to the sampleCases array. This is consistent with the changes in other files where 'contact_us_forms' is added as a new task template. The change is correct and aligns with the PR description.

Workflow ID: wflow_7ywGu0CCYWCguAmx


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit dcca1a6 into main Oct 14, 2024
2 checks passed
@msalihaltun msalihaltun deleted the salih/workflow-run-page branch October 14, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants