Add help text to other nodes #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add help tooltips to various nodes and update default code and spacing in `CodeBlockNode`. > > - **Help Tooltips**: > - Added `HelpTooltip` to `DownloadNode`, `FileParserNode`, `LoopNode`, `SendEmailNode`, `TextPromptNode`, and `UploadNode` for specific fields. > - Tooltip content defined in `types.ts` for each node type. > - **CodeBlockNode**: > - Updated default `code` in `codeBlockNodeDefaultData` to include instructions for using the `result` variable. > - Adjusted spacing in `CodeBlockNode.tsx` from `space-y-1` to `space-y-2`. > - **UI Adjustments**: > - Changed spacing from `space-y-1` to `space-y-2` in `SendEmailNode.tsx` and `TextPromptNode.tsx` for better layout consistency. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 348fc08e4f96899211cc43ee3e090b8fb3f3cc89. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 45df222 in 14 seconds
More details
- Looked at
363lines of code in15files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/DownloadNode/types.ts:18
- Draft comment:
Consider centralizinghelpTooltipContentto avoid repetition across multiple files. This will make it easier to maintain and update tooltip content. - Reason this comment was not posted:
Confidence changes required:50%
The PR introduces help tooltips for various nodes, but the tooltip content is repeated across multiple files. This can lead to maintenance issues if the content needs to be updated. A centralized approach would be more efficient.
Workflow ID: wflow_IuZoeEtDtoR5jLex
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 45df222 in 15 seconds
More details
- Looked at
363lines of code in15files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/DownloadNode/types.ts:18
- Draft comment:
Consider centralizinghelpTooltipContentdefinitions to avoid repetition and ease maintenance. This pattern is repeated in other node types as well. - Reason this comment was not posted:
Confidence changes required:50%
The PR introduces help tooltips for various nodes, but the tooltip content is repeated across multiple files. This can lead to maintenance issues if the content needs to be updated. A centralized approach would be more efficient.
Workflow ID: wflow_HXugJ3u2rOVIMVn6
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add help tooltips to various nodes and update default code and spacing in
CodeBlockNode.HelpTooltiptoDownloadNode,FileParserNode,LoopNode,SendEmailNode,TextPromptNode, andUploadNodefor specific fields.types.tsfor each node type.codeincodeBlockNodeDefaultDatato include instructions for using theresultvariable.CodeBlockNode.tsxfromspace-y-1tospace-y-2.space-y-1tospace-y-2inSendEmailNode.tsxandTextPromptNode.tsxfor better layout consistency.This description was created by
for 45df222. It will automatically update as commits are pushed.