Make timeline background full height even when empty #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Ensure `WorkflowRunTimeline` maintains full height by setting `h-[37rem]` in `ScrollAreaViewport` class. > > - **Behavior**: > - Modify `ScrollAreaViewport` class in `WorkflowRunTimeline.tsx` to set `h-[37rem]` alongside `max-h-[37rem]` to ensure full height even when empty. > - **Files Affected**: > - `WorkflowRunTimeline.tsx` in `eval/routes/workflows/` and `src/routes/workflows/workflowRun/`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for f35ca31b74c568ee2406b676339bbebe3cb8995b. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 0441eed in 15 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowRunTimeline.tsx:82
- Draft comment:
Adding a fixed height class (h-[37rem]) ensures full background height, but consider potential responsiveness issues. Verify if a responsive solution (e.g., using min-h or responsive breakpoints) might be better. - Reason this comment was not posted:
Comment did not seem useful.
2. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowRunTimeline.tsx:82
- Draft comment:
Added h-[37rem] fixes the empty timeline height. Consider if max-h-[37rem] is redundant since a fixed height is already applied. - Reason this comment was not posted:
Confidence changes required:0%
None
Workflow ID: wflow_NM3ytmbk1u13dy17
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0441eed in 21 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowRunTimeline.tsx:82
- Draft comment:
Using both 'h-[37rem]' and 'max-h-[37rem]' may be redundant. If a fixed height is intended, only 'h-[37rem]' might suffice; consider removing 'max-h-[37rem]' for clarity. - Reason this comment was not posted:
Confidence changes required:33%
None
2. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowRunTimeline.tsx:82
- Draft comment:
Good fix to ensure a full-height timeline background when empty. However, using both 'h-[37rem]' and 'max-h-[37rem]' is redundant if a fixed height is intended. Consider using 'min-h-[37rem]' if you want the container to expand when additional content is present, or add a comment explaining the design decision. - Reason this comment was not posted:
Confidence changes required:33%
None
Workflow ID: wflow_VWlRR3qxWydMZ2El
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
msalihaltun
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Modify
ScrollAreaViewportclass inWorkflowRunTimeline.tsxfor full height background when empty.ScrollAreaViewportclass inWorkflowRunTimeline.tsxtoh-[37rem] max-h-[37rem]to ensure full height background even when empty.This description was created by
for 0441eed. It will automatically update as commits are pushed.