When observer run, use observer task to get callback url and proxy lo…

[wintonzheng]

…cation

---

Important

Update WorkflowPostRunParameters.tsx to prioritize observer task URLs and proxy location, and extend ObserverTask type in types.ts.

• Behavior:
  • Update WorkflowPostRunParameters.tsx to use observer_task's webhook_callback_url and proxy_location if present, otherwise use workflowRun values.
• Types:
  • Add webhook_callback_url, totp_verification_url, totp_identifier, and proxy_location to ObserverTask in types.ts.

^{This description was created by for e7895ce. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to e7895ce in 33 seconds

More details

• Looked at 52 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 6 drafted comments based on config settings.

1. skyvern-frontend/src/api/types.ts:285

• Draft comment:
  New fields (webhook_callback_url, totp_verification_url, totp_identifier, proxy_location) were added to ObserverTask. Ensure the backend returns these fields consistently with the schema.
• Reason this comment was not posted:
  Confidence changes required: 0%
  None

2. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowPostRunParameters.tsx:47

• Draft comment:
  Using observer_task values for webhook_callback_url and proxy_location is clear. Confirm that observer task values should override workflowRun's own values.
• Reason this comment was not posted:
  Confidence changes required: 0%
  None

3. skyvern-frontend/src/api/types.ts:285

• Draft comment:
  New fields added to ObserverTask. Consider adding inline comments or docs to clarify usage and ensure consistency with backend specs.
• Reason this comment was not posted:
  Confidence changes required: 33%
  None

4. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowPostRunParameters.tsx:47

• Draft comment:
  Consider using a truthy check (e.g., if (workflowRun.observer_task)) instead of comparing explicitly to null for better readability.
• Reason this comment was not posted:
  Confidence changes required: 33%
  None

5. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowPostRunParameters.tsx:49

• Draft comment:
  The fallback logic (using workflowRun.observer_task?.webhook_callback_url vs. workflowRun.webhook_callback_url) is appropriate; ensure that null values are handled as expected.
• Reason this comment was not posted:
  Confidence changes required: 0%
  None

6. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowPostRunParameters.tsx:143

• Draft comment:
  ProxySelector's onChange handler is still a TODO; ensure to implement or provide a noop to prevent potential issues.
• Reason this comment was not posted:
  Confidence changes required: 33%
  None

Workflow ID: wflow_kvh7INs9TAGh5dIe

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on e7895ce in 36 seconds

More details

• Looked at 52 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 6 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowPostRunParameters.tsx:47

• Draft comment:
  Consider extracting observer task fallback logic into a helper function to reduce duplication. This ensures consistent handling if more observer properties are needed in future.
• Reason this comment was not posted:
  Confidence changes required: 50%
  None

2. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowPostRunParameters.tsx:137

• Draft comment:
  Using computed webhookCallbackUrl and proxyLocation improves clarity. Ensure that if observer_task fields become optional or undefined, appropriate fallbacks are provided.
• Reason this comment was not posted:
  Confidence changes required: 30%
  None

3. skyvern-frontend/src/api/types.ts:285

• Draft comment:
  New properties added to ObserverTask. Consider adding inline comments to clarify when each field (webhook_callback_url, totp_verification_url, totp_identifier, proxy_location) should be used.
• Reason this comment was not posted:
  Confidence changes required: 33%
  None

4. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowPostRunParameters.tsx:47

• Draft comment:
  Logic for selecting observer task fields is duplicated. Consider destructuring observer_task to simplify assignment of webhookCallbackUrl and proxyLocation.
• Reason this comment was not posted:
  Confidence changes required: 33%
  None

5. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowPostRunParameters.tsx:152

• Draft comment:
  Observer task block renders only the prompt. If totp_verification_url and totp_identifier are important, consider displaying them or add a TODO note for future UI enhancements.
• Reason this comment was not posted:
  Confidence changes required: 33%
  None

6. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowPostRunParameters.tsx:144

• Draft comment:
  The ProxySelector's onChange handler is marked as TODO. Remember to implement the update logic for proxyLocation when a value is selected.
• Reason this comment was not posted:
  Confidence changes required: 33%
  None

Workflow ID: wflow_ZUZLlhz0aDwYSIzG

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.