Add Task v2 Block #1683
Merged
Add Task v2 Block #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add Task v2 Block to Skyvern workflow editor with new node type, UI components, and YAML conversion logic. > > - **Behavior**: > - Introduces `Taskv2Node` in `Taskv2Node.tsx` with properties like `prompt`, `url`, `maxIterations`, `totpVerificationUrl`, and `totpIdentifier`. > - Adds `taskv2` to `helpTooltips` and `placeholders` in `helpContent.ts` with specific content for `maxIterations` and `prompt`. > - Updates `WorkflowNodeLibraryPanel.tsx` to include `Task v2 Block` in the node library. > - **Models**: > - Defines `Taskv2NodeData` and `Taskv2Node` types in `types.ts` with default values. > - Adds `Taskv2Block` type to `workflowTypes.ts` and `Taskv2BlockYAML` to `workflowYamlTypes.ts`. > - **UI Components**: > - Updates `WorkflowBlockIcon.tsx` to use `ListBulletIcon` for `task_v2`. > - Adds `Taskv2NodeComponent` to `index.ts` for node registration. > - **YAML Conversion**: > - Updates `workflowEditorUtils.ts` to handle `task_v2` in `convertToNode`, `createNode`, `getWorkflowBlock`, and `convertBlocksToBlockYAML`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for c84b962e0c7b079036cc5ea9d84ae1744f3ff1fe. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add Task v2 Block to Skyvern workflow editor with new node type, UI components, and YAML conversion logic. > > - **Behavior**: > - Introduces `Taskv2Node` in `Taskv2Node.tsx` with properties like `prompt`, `url`, `maxIterations`, `totpVerificationUrl`, and `totpIdentifier`. > - Adds `taskv2` to `helpTooltips` and `placeholders` in `helpContent.ts` with specific content for `maxIterations` and `prompt`. > - Updates `WorkflowNodeLibraryPanel.tsx` to include `Task v2 Block` in the node library. > - **Models**: > - Defines `Taskv2NodeData` and `Taskv2Node` types in `types.ts` with default values. > - Adds `Taskv2Block` type to `workflowTypes.ts` and `Taskv2BlockYAML` to `workflowYamlTypes.ts`. > - **UI Components**: > - Updates `WorkflowBlockIcon.tsx` to use `ListBulletIcon` for `task_v2`. > - Adds `Taskv2NodeComponent` to `index.ts` for node registration. > - **YAML Conversion**: > - Updates `workflowEditorUtils.ts` to handle `task_v2` in `convertToNode`, `createNode`, `getWorkflowBlock`, and `convertBlocksToBlockYAML`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for c84b962e0c7b079036cc5ea9d84ae1744f3ff1fe. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 2650f61 in 1 minute and 37 seconds
More details
- Looked at
513lines of code in12files - Skipped
0files when reviewing. - Skipped posting
7drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/nodes/WorkflowBlockIcon.tsx:57
- Draft comment:
Inconsistent naming: 'task_v2' is used here, but 'taskv2' is used elsewhere. Ensure consistent naming across the codebase to avoid confusion and potential bugs. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment points to a potential cross-file issue, claiming there's inconsistent naming in other parts of the codebase. However, we can only see this file, and one of our rules is to ignore cross-file issues. We can't verify if there's actually an inconsistency without seeing the other files where 'taskv2' is supposedly used.
What if this inconsistency actually exists and could cause real problems? What if this is a legitimate concern that should be addressed?
While the inconsistency might exist, we're explicitly told to ignore cross-file issues and only focus on the file being reviewed. We don't have strong evidence within this file to support keeping this comment.
Delete the comment because it refers to a potential cross-file issue that we can't verify within the scope of this file review.
2. skyvern-frontend/src/routes/workflows/editor/nodes/index.ts:60
- Draft comment:
Inconsistent naming: 'taskv2' is used here, but 'task_v2' is used elsewhere. Ensure consistent naming across the codebase to avoid confusion and potential bugs. - Reason this comment was not posted:
Marked as duplicate.
3. skyvern-frontend/src/routes/workflows/editor/nodes/types.ts:49
- Draft comment:
Inconsistent naming: 'task_v2' is used here, but 'taskv2' is used elsewhere. Ensure consistent naming across the codebase to avoid confusion and potential bugs. - Reason this comment was not posted:
Marked as duplicate.
4. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowNodeLibraryPanel.tsx:71
- Draft comment:
Inconsistent naming: 'taskv2' is used here, but 'task_v2' is used elsewhere. Ensure consistent naming across the codebase to avoid confusion and potential bugs. - Reason this comment was not posted:
Marked as duplicate.
5. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:208
- Draft comment:
Inconsistent naming: 'taskv2' is used here, but 'task_v2' is used elsewhere. Ensure consistent naming across the codebase to avoid confusion and potential bugs. - Reason this comment was not posted:
Marked as duplicate.
6. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:674
- Draft comment:
Inconsistent naming: 'taskv2' is used here, but 'task_v2' is used elsewhere. Ensure consistent naming across the codebase to avoid confusion and potential bugs. - Reason this comment was not posted:
Marked as duplicate.
7. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:893
- Draft comment:
Inconsistent naming: 'task_v2' is used here, but 'taskv2' is used elsewhere. Ensure consistent naming across the codebase to avoid confusion and potential bugs. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_Nc7QnOgCby4oye3g
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 2650f61 in 1 minute and 37 seconds
More details
- Looked at
541lines of code in13files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_f28w7Fc93PrxDsVH
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
skyvern/forge/sdk/schemas/tasks.py
Outdated
| @@ -64,14 +63,11 @@ def get_tzinfo_from_proxy(proxy_location: ProxyLocation) -> ZoneInfo | None: | |||
| return ZoneInfo("Asia/Kolkata") | |||
|
|
|||
| if proxy_location == ProxyLocation.RESIDENTIAL_JP: | |||
| return ZoneInfo("Asia/Tokyo") | |||
| return ZoneInfo("Asia/Kolkata") | |||
There was a problem hiding this comment.
The timezone for ProxyLocation.RESIDENTIAL_JP should be Asia/Tokyo instead of Asia/Kolkata.
msalihaltun
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 5beb30c in 18 seconds
More details
- Looked at
54lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/schemas/tasks.py:66
- Draft comment:
Corrected timezone forRESIDENTIAL_JPfromAsia/KolkatatoAsia/Tokyo. Ensure this change is intentional and consistent with the application's requirements. - Reason this comment was not posted:
Confidence changes required:50%
The PR adds a new proxy location 'ResidentialDE' to the ProxyLocation enum and updates the ProxySelector component to include this new location. The changes are consistent across the files, ensuring that the new proxy location is available in both the frontend and backend. However, there is a minor issue with the timezone mapping for 'RESIDENTIAL_JP' in the get_tzinfo_from_proxy function, which was corrected in this PR. The rest of the changes are straightforward and align with the intent of adding a new proxy location.
Workflow ID: wflow_OQ0pl9KbZsTbdIo7
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add Task v2 Block to Skyvern workflow editor with new node type, UI components, and YAML support.
Taskv2NodeinTaskv2Node.tsxto handle Task v2 blocks with properties likeprompt,url,maxIterations,totpVerificationUrl, andtotpIdentifier.taskv2tohelpContent.tswith specific tooltips and placeholders.Taskv2NodeDataandTaskv2Nodetypes intypes.ts.WorkflowBlockTypesandWorkflowBlockinworkflowTypes.tsto includetask_v2.Taskv2BlockYAMLtype inworkflowYamlTypes.ts.WorkflowBlockIcon.tsxto include icon fortask_v2.Taskv2Nodetoindex.tsandWorkflowNodeLibraryPanel.tsxfor node library integration.workflowEditorUtils.tsto handle conversion and creation oftask_v2nodes and YAML blocks.This description was created by
for 5beb30c. It will automatically update as commits are pushed.