Add DE Proxy #1678
Merged
Add DE Proxy #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- **Add org index to the actions table**
- **Add DE Proxy**
<!-- ELLIPSIS_HIDDEN -->
----
> [!IMPORTANT]
> Add support for 'RESIDENTIAL_DE' proxy location across database, configuration, proxy management, and frontend components.
>
> - **Database**:
> - Add 'RESIDENTIAL_DE' to `proxylocation` enum in `add_residential_de_proxy.py`.
> - **Configuration**:
> - Add `WEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_DE` to `CloudSettings` in `config.py`.
> - Update `job-definition-production.json`, `job-definition-staging.json`, `observer-definition-production.json`, `observer-definition-staging.json`, `task-definition-staging.json`, `worker-staging-terraform/temporal_worker.tf`, `worker-terraform/temporal_worker.tf`, `workflow-job-definition-production.json`, and `workflow-job-definition-staging.json` to include `WEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_DE`.
> - **Proxy Management**:
> - Add `RESIDENTIAL_DE` to `ProxyLocation` in `proxy.py` and handle it in `build_proxy_config_webshare_io()` and `build_proxy_config()`.
> - **Frontend**:
> - Add `ResidentialDE` to `ProxyLocation` in `types.ts`.
> - Update `ProxySelector.tsx` to include 'Residential (Germany)'.
> - **Miscellaneous**:
> - Update `get_tzinfo_from_proxy()` in `tasks.py` to return `ZoneInfo("Europe/Berlin")` for `RESIDENTIAL_DE`.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for b0ca88184450448608fe17f2880c3d0dfd2748cc. It will automatically update as commits are pushed.</sup>
<!-- ELLIPSIS_HIDDEN -->
…src/'
- **Add org index to the actions table**
- **Add DE Proxy**
<!-- ELLIPSIS_HIDDEN -->
----
> [!IMPORTANT]
> Add support for 'RESIDENTIAL_DE' proxy location across database, configuration, proxy management, and frontend components.
>
> - **Database**:
> - Add 'RESIDENTIAL_DE' to `proxylocation` enum in `add_residential_de_proxy.py`.
> - **Configuration**:
> - Add `WEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_DE` to `CloudSettings` in `config.py`.
> - Update `job-definition-production.json`, `job-definition-staging.json`, `observer-definition-production.json`, `observer-definition-staging.json`, `task-definition-staging.json`, `worker-staging-terraform/temporal_worker.tf`, `worker-terraform/temporal_worker.tf`, `workflow-job-definition-production.json`, and `workflow-job-definition-staging.json` to include `WEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_DE`.
> - **Proxy Management**:
> - Add `RESIDENTIAL_DE` to `ProxyLocation` in `proxy.py` and handle it in `build_proxy_config_webshare_io()` and `build_proxy_config()`.
> - **Frontend**:
> - Add `ResidentialDE` to `ProxyLocation` in `types.ts`.
> - Update `ProxySelector.tsx` to include 'Residential (Germany)'.
> - **Miscellaneous**:
> - Update `get_tzinfo_from_proxy()` in `tasks.py` to return `ZoneInfo("Europe/Berlin")` for `RESIDENTIAL_DE`.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for b0ca88184450448608fe17f2880c3d0dfd2748cc. It will automatically update as commits are pushed.</sup>
<!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 484b4e0 in 9 seconds
More details
- Looked at
26lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_cvSKEj8ntSU6eHMp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 484b4e0 in 16 seconds
More details
- Looked at
54lines of code in3files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. skyvern-frontend/src/api/types.ts:38
- Draft comment:
Ensure that the new proxy location 'ResidentialDE' is used consistently across the codebase. It seems to be correctly added here and in the related files. - Reason this comment was not posted:
Confidence changes required:20%
The PR adds a new proxy location 'ResidentialDE' to the ProxyLocation enum and updates the ProxySelector component to include this new option. The changes are consistent across the files, ensuring that the new proxy location is available in both the frontend and backend logic.
2. skyvern-frontend/src/components/ProxySelector.tsx:42
- Draft comment:
The addition of 'Residential (Germany)' is consistent with the new proxy location 'ResidentialDE'. Ensure this is reflected in any related documentation or UI tests. - Reason this comment was not posted:
Confidence changes required:20%
The PR correctly updates the ProxySelector component to include the new 'ResidentialDE' option. This ensures that users can select the new proxy location from the UI.
3. skyvern/forge/sdk/schemas/tasks.py:72
- Draft comment:
The addition of 'ResidentialDE' with 'Europe/Berlin' timezone is correct. Ensure this is consistent with any other timezone-related logic in the codebase. - Reason this comment was not posted:
Confidence changes required:20%
The PR correctly updates the get_tzinfo_from_proxy function to return the appropriate timezone for the new 'ResidentialDE' proxy location. This ensures that the correct timezone is used when this proxy is selected.
Workflow ID: wflow_FrsAaYO0kbIrwt7B
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b1d93fc in 13 seconds
More details
- Looked at
36lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. alembic/versions/2025_01_29_0554-5dd8928389c5_add_residential_de_proxy.py:28
- Draft comment:
Consider adding a comment explaining why the downgrade operation is a no-op, as removing enum values in PostgreSQL is not straightforward and can cause issues. - Reason this comment was not posted:
Confidence changes required:50%
The PR adds a new value to an enum type in PostgreSQL, which is a one-way operation. The downgrade function is correctly left as a no-op since removing enum values in PostgreSQL is not straightforward and can cause issues if not handled properly. However, it's important to note this limitation in the comments for future reference.
Workflow ID: wflow_zisbwrxfVzePzK7w
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
suchintan
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add 'RESIDENTIAL_DE' proxy location to database, frontend, and backend systems.
RESIDENTIAL_DEtoproxylocationenum inadd_residential_de_proxy.py.ResidentialDEtoProxyLocationintypes.ts.ProxySelector.tsxto include "Residential (Germany)" option.RESIDENTIAL_DEtoProxyLocationenum intasks.py.get_tzinfo_from_proxy()intasks.pyto returnEurope/BerlinforRESIDENTIAL_DE.This description was created by
for b1d93fc. It will automatically update as commits are pushed.