Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync - deleteOrphaned: true #1505

Merged
merged 1 commit into from
Jan 6, 2025
Merged

sync - deleteOrphaned: true #1505

merged 1 commit into from
Jan 6, 2025

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Jan 6, 2025

according to https://github.com/marketplace/actions/repo-file-sync-action#delete-orphaned-files, we want to make sure we also delete files in the cloud repo if they're deleted in the open source side.

Important

Add deleteOrphaned: true to sync operations for skyvern/ and skyvern-frontend/src/ in .github/sync.yml.

  • Sync Configuration:
    • Adds deleteOrphaned: true to skyvern/ sync operation in .github/sync.yml.
    • Adds deleteOrphaned: true to skyvern-frontend/src/ sync operation in .github/sync.yml.

This description was created by Ellipsis for 8efa0b4. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8efa0b4 in 15 seconds

More details
  • Looked at 19 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/sync.yml:4
  • Draft comment:
    Ensure that deleteOrphaned: true is intended, as it will remove files in the destination that are not present in the source. This can lead to data loss if not used carefully.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_4qvb4IwcPMs7fjPS


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit be05a94 into main Jan 6, 2025
2 checks passed
@wintonzheng wintonzheng deleted the shu/support_delete_sync branch January 6, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant