Make collection id required #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Make `collectionId` required for `credential` parameters in `WorkflowParameterAddPanel` and `WorkflowParameterEditPanel`, with error handling and toast message updates. > > - **Behavior**: > - Enforce `collectionId` requirement for `credential` type in `WorkflowParameterAddPanel` and `WorkflowParameterEditPanel`. > - Display error toast if `collectionId` is missing when saving. > - **UI**: > - Update toast titles from "Failed to save parameters" to "Failed to add parameter" or "Failed to save parameter" for consistency. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for a1c03cfd87dc5f0dbeacf0ca66f05cd3c32c4d17. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 7b97d1d in 9 seconds
More details
- Looked at
75lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterAddPanel.tsx:208
- Draft comment:
The toast title was updated correctly here. Ensure similar updates are made in other relevant places for consistency. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions updating toast titles for consistency. The title for the 'credential' type in the WorkflowParameterEditPanel was updated correctly, but the WorkflowParameterAddPanel also needed this update.
2. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterAddPanel.tsx:234
- Draft comment:
The toast title was updated correctly here. Ensure similar updates are made in other relevant places for consistency. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions updating toast titles for consistency. The title for the 'credential' type in the WorkflowParameterEditPanel was updated correctly, but the WorkflowParameterAddPanel also needed this update.
Workflow ID: wflow_TwYD6sXIgbz3jY6G
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 7b97d1d in 10 seconds
More details
- Looked at
75lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterAddPanel.tsx:250
- Draft comment:
The toast title for the 'context' type should be updated to "Failed to add parameter" for consistency with other types. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions updating toast titles for consistency. The changes in the code reflect this update, but there is a minor inconsistency in the toast title for the 'context' type in the WorkflowParameterAddPanel. It should be updated for consistency.
2. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterEditPanel.tsx:283
- Draft comment:
The toast title for the 'context' type should be updated to "Failed to save parameter" for consistency with other types. - Reason this comment was not posted:
Confidence changes required:50%
The PR description mentions updating toast titles for consistency. The changes in the code reflect this update, but there is a minor inconsistency in the toast title for the 'context' type in the WorkflowParameterEditPanel. It should be updated for consistency.
Workflow ID: wflow_anludPRrSB8jiYSr
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Enforce
collectionIdrequirement forcredentialparameters inWorkflowParameterAddPanelandWorkflowParameterEditPanel, with updated error handling and toast messages.collectionIdrequirement forcredentialtype inWorkflowParameterAddPanelandWorkflowParameterEditPanel.collectionIdis missing when saving.This description was created by
for 7b97d1d. It will automatically update as commits are pushed.