kiosk printing

[LawyZheng]

Important

Add kiosk printing support by introducing --kiosk-printing argument and removing unused code.

• Behavior:
  • Add --kiosk-printing argument to build_browser_args() in browser_factory.py to enable automatic printing.
• Code Cleanup:
  • Remove unused DISABLE_PRINTER_WITH_FLAG JavaScript snippet from page.py.
  • Remove unused PDF download logic from handle_click_to_download_file_action() in handler.py.

^{This description was created by for 7c1274e. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to cae4b90 in 50 seconds

More details

• Looked at 34 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_Yw2adooBWEhVj6wl

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

The get_print_triggered and reset_print_triggered methods reference window.__printTriggered, which is no longer set due to the removal of the DISABLE_PRINTER_WITH_FLAG script. This could lead to logical errors if these methods are used.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 7c1274e in 25 seconds

More details

• Looked at 61 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/webeye/utils/page.py:118

• Draft comment:
  The get_print_triggered and reset_print_triggered methods related to the DISABLE_PRINTER_WITH_FLAG snippet should be removed as they are unused. This applies to the entire SkyvernFrame class if these methods are the only ones using the snippet.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The comment is about methods that were removed in the diff, so it is relevant to the changes. However, the part about the SkyvernFrame class is speculative and not directly related to the change. The comment should be partially kept, focusing only on the removed methods.
  I might be overanalyzing the speculative part of the comment. The entire comment could be seen as relevant since it addresses the removed methods.
  The speculative part about the SkyvernFrame class is not necessary for understanding the change made in the diff. The focus should be on the removed methods.
  Keep the part of the comment that addresses the removal of the get_print_triggered and reset_print_triggered methods, but remove the speculative part about the SkyvernFrame class.

Workflow ID: wflow_J1obZkXyti9Zw4Sb

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.