Improve run workflow form

[wintonzheng]

Important

Enhance workflow parameter forms with improved UI, error handling, and default value management.

• UI Improvements:
  • Replace table layout with form layout in RunWorkflowForm.tsx.
  • Add FormLabel for parameter descriptions in RunWorkflowForm.tsx.
  • Use Skeleton for loading state in WorkflowRunParameters.tsx.
• Functionality:
  • Handle JSON parsing errors in parseValuesForWorkflowRun() in RunWorkflowForm.tsx.
  • Set default values to null if not provided in WorkflowRunParameters.tsx.
  • Adjust WorkflowParameterInput.tsx to handle null values for integer and float types.
• Parameter Handling:
  • Remove defaultValue() function and handle defaults inline in WorkflowRunParameters.tsx.
  • Update WorkflowParameterAddPanel.tsx and WorkflowParameterEditPanel.tsx to handle default values more robustly.

^{This description was created by for 1801f2c. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Incremental review on 1801f2c in 33 seconds

More details

• Looked at 423 lines of code in 5 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/WorkflowParameterInput.tsx:44

• Draft comment:
  Consider adding a check for NaN after parsing the input to handle invalid number inputs gracefully.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code in WorkflowParameterInput.tsx handles different input types, including JSON, string, integer, float, boolean, and file_url. However, the integer and float types use parseInt and parseFloat without checking for NaN, which could lead to unexpected behavior if the input is not a valid number.

2. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterEditPanel.tsx:259

• Draft comment:
  Ensure consistency by setting defaultValue: value.s3uri for file_url type, similar to WorkflowParameterAddPanel.tsx.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_YfhXpZLBe1rtUZEQ

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 1801f2c in 1 minute and 3 seconds

More details

• Looked at 423 lines of code in 5 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/WorkflowParameterInput.tsx:44

• Draft comment:
  Consider adding validation to ensure the input is a valid number before calling parseInt or parseFloat. This will prevent NaN from being set as the value.
• Reason this comment was not posted:
  Comment was on unchanged code.

2. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterEditPanel.tsx:254

• Draft comment:
  Consider refactoring the JSON defaultValue logic into a utility function to reduce code duplication and potential errors. This logic is also present in the WorkflowParameterAddPanel.tsx.
• Reason this comment was not posted:
  Confidence changes required: 50%
  In WorkflowParameterEditPanel.tsx, the defaultValue logic for JSON parameters is repeated in both the Add and Edit panels. This could be refactored into a utility function to reduce code duplication and potential errors.

Workflow ID: wflow_LOK2DZqEx8sB8YZ7

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.