Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install html lang for codemirror #1023

Merged

Conversation

msalihaltun
Copy link
Collaborator

@msalihaltun msalihaltun commented Oct 22, 2024

Important

Add @codemirror/lang-html to dependencies in package.json.

  • Dependencies:
    • Add @codemirror/lang-html version ^6.4.9 to dependencies in package.json.

This description was created by Ellipsis for f2502aa. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f2502aa in 11 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/package.json:19
  • Draft comment:
    Ensure that @codemirror/lang-html is actually used in the codebase to justify its inclusion. If not, consider removing it to avoid unnecessary dependencies.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The addition of the @codemirror/lang-html package seems straightforward and correct given the PR title. However, it's important to ensure that this package is actually used in the codebase to justify its inclusion.

Workflow ID: wflow_OnQ8NBdhR9YaWEKL


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit 439815c into Skyvern-AI:main Oct 22, 2024
2 checks passed
@msalihaltun msalihaltun deleted the install-codemirror-lang-html branch October 22, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant